Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment (Closed)

Created:
4 years, 8 months ago by alancutter (OOO until 2018)

Modified:
3 years, 7 months ago

Reviewers:

CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans

Base URL:
https://chromium.googlesource.com/chromium/src.git@_transformInterpolationType

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add ComputedStyle constructor and getter to InterpolationEnvironment This is in preparation for migration transitions over to using InterpolationTypes. BUG=

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -60 lines)			Patch
M	third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSMotionRotationInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/InterpolationEnvironment.h	View	1	2 chunks	+16 lines, -7 lines	0 comments	Download
A	third_party/WebKit/Source/core/animation/InterpolationEnvironment.cpp	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/core.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 2236193002 Patch 1

Issue 1850433003 Patch 40001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

alancutter (OOO until 2018)

4 years, 6 months ago (2016-06-08 08:14:21 UTC) #1

Description was changed from

==========
Add ComputedStyle constructor and getter to InterpolationEnvironment

BUG=
==========

to

==========
Add ComputedStyle constructor and getter to InterpolationEnvironment

This is in preparation for migration transitions over to using
InterpolationTypes.

BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages