third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp - Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_transformInterpolationType

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

index f3d3a359b35b63f92eac5c40ac125495492a558c..0166cfc23ed9f2af7884757d83ace997e1e826b9 100644

--- a/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp

@@ -223,9 +223,10 @@ InterpolationValue CSSClipInterpolationType::maybeConvertValue(const CSSValue& v

InterpolationValue CSSClipInterpolationType::maybeConvertUnderlyingValue(const InterpolationEnvironment& environment) const

{

- if (environment.state().style()->hasAutoClip())

+ const ComputedStyle& style = environment.style();

+ if (style.hasAutoClip())

return nullptr;

- return createClipValue(environment.state().style()->clip(), environment.state().style()->effectiveZoom());

+ return createClipValue(style.clip(), style.effectiveZoom());

}

PairwiseInterpolationValue CSSClipInterpolationType::maybeMergeSingles(InterpolationValue&& start, InterpolationValue&& end) const

@@ -257,7 +258,7 @@ void CSSClipInterpolationType::apply(const InterpolableValue& interpolableValue,

return Length(Auto);

return CSSLengthInterpolationType::resolveInterpolableLength(*list.get(index), nullptr, environment.state().cssToLengthConversionData(), ValueRangeAll);

};

- environment.state().style()->setClip(LengthBox(

+ environment.style().setClip(LengthBox(

convertIndex(autos.isTopAuto, ClipTop),

convertIndex(autos.isRightAuto, ClipRight),

convertIndex(autos.isBottomAuto, ClipBottom),