third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp - Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp

Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_transformInterpolationType

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp

index d9eb7a8c6c20c28cf23c8afaa65c0b22bc4932f1..07892030e4c78b15a0160905c33e7933eb366448 100644

--- a/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp

@@ -157,7 +157,7 @@ PairwiseInterpolationValue CSSRotateInterpolationType::maybeMergeSingles(Interpo

InterpolationValue CSSRotateInterpolationType::maybeConvertUnderlyingValue(const InterpolationEnvironment& environment) const

{

- return convertRotation(getRotation(*environment.state().style()));

+ return convertRotation(getRotation(environment.style()));

}

void CSSRotateInterpolationType::composite(UnderlyingValueOwner& underlyingValueOwner, double underlyingFraction, const InterpolationValue& value, double interpolationFraction) const

@@ -173,7 +173,7 @@ void CSSRotateInterpolationType::apply(const InterpolableValue& interpolableValu

double progress = toInterpolableNumber(interpolableValue).value();

const CSSRotateNonInterpolableValue& nonInterpolableValue = toCSSRotateNonInterpolableValue(*untypedNonInterpolableValue);

Rotation rotation = nonInterpolableValue.slerpedRotation(progress);

- environment.state().style()->setRotate(RotateTransformOperation::create(rotation, TransformOperation::Rotate3D));

+ environment.style().setRotate(RotateTransformOperation::create(rotation, TransformOperation::Rotate3D));

}