third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp - Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_transformInterpolationType

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSMotionRotationInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

index b2df15d02eecdb5dbdce7f303437b47f5ed02385..640d579b8856c6f8ea4a608e407cdc0bc8fbdee7 100644

--- a/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp

@@ -76,7 +76,7 @@ InterpolationValue CSSNumberInterpolationType::maybeConvertValue(const CSSValue&

InterpolationValue CSSNumberInterpolationType::maybeConvertUnderlyingValue(const InterpolationEnvironment& environment) const

{

double underlyingNumber;

- if (!NumberPropertyFunctions::getNumber(cssProperty(), *environment.state().style(), underlyingNumber))

+ if (!NumberPropertyFunctions::getNumber(cssProperty(), environment.style(), underlyingNumber))

return nullptr;

return createNumberValue(underlyingNumber);

}

@@ -84,7 +84,7 @@ InterpolationValue CSSNumberInterpolationType::maybeConvertUnderlyingValue(const

void CSSNumberInterpolationType::apply(const InterpolableValue& interpolableValue, const NonInterpolableValue*, InterpolationEnvironment& environment) const

{

double clampedNumber = NumberPropertyFunctions::clampNumber(cssProperty(), toInterpolableNumber(interpolableValue).value());

- if (!NumberPropertyFunctions::setNumber(cssProperty(), *environment.state().style(), clampedNumber))

+ if (!NumberPropertyFunctions::setNumber(cssProperty(), environment.style(), clampedNumber))

StyleBuilder::applyProperty(cssProperty(), environment.state(), *CSSPrimitiveValue::create(clampedNumber, CSSPrimitiveValue::UnitType::Number));

}