third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp - Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_transformInterpolationType

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/InterpolationEnvironment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

index caf47737bc4ec1187e9a42f99d5d16673c9d4354..efaa5c3741d26ab4c7be4356f45b8e4f6f151039 100644

--- a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

@@ -145,7 +145,7 @@ InterpolationValue CSSVisibilityInterpolationType::maybeConvertValue(const CSSVa

InterpolationValue CSSVisibilityInterpolationType::maybeConvertUnderlyingValue(const InterpolationEnvironment& environment) const

{

- return createVisibilityValue(environment.state().style()->visibility());

+ return createVisibilityValue(environment.style().visibility());

}

PairwiseInterpolationValue CSSVisibilityInterpolationType::maybeMergeSingles(InterpolationValue&& start, InterpolationValue&& end) const

@@ -168,7 +168,7 @@ void CSSVisibilityInterpolationType::apply(const InterpolableValue& interpolable

// Visibility interpolation has been deferred to application time here due to its non-linear behaviour.

double fraction = toInterpolableNumber(interpolableValue).value();

EVisibility visibility = toCSSVisibilityNonInterpolableValue(nonInterpolableValue)->visibility(fraction);

- environment.state().style()->setVisibility(visibility);

+ environment.style().setVisibility(visibility);

}

} // namespace blink