third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp - Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

Issue 1885353004: Add ComputedStyle constructor and getter to InterpolationEnvironment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_transformInterpolationType

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

index f406ced3e1304ddc02adbb02d8250829c734aa54..c1017ecd5a4b761a961e8ac03b5e36db749da052 100644

--- a/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

@@ -17,10 +17,10 @@ void CSSPathInterpolationType::apply(const InterpolableValue& interpolableValue,

ASSERT(cssProperty() == CSSPropertyD);

std::unique_ptr<SVGPathByteStream> pathByteStream = PathInterpolationFunctions::appliedValue(interpolableValue, nonInterpolableValue);

if (pathByteStream->isEmpty()) {

- environment.state().style()->setD(nullptr);

+ environment.style().setD(nullptr);

return;

}

- environment.state().style()->setD(StylePath::create(std::move(pathByteStream)));

+ environment.style().setD(StylePath::create(std::move(pathByteStream)));

}

void CSSPathInterpolationType::composite(UnderlyingValueOwner& underlyingValueOwner, double underlyingFraction, const InterpolationValue& value, double interpolationFraction) const

@@ -80,7 +80,7 @@ InterpolationValue CSSPathInterpolationType::maybeConvertValue(const CSSValue& v

InterpolationValue CSSPathInterpolationType::maybeConvertUnderlyingValue(const InterpolationEnvironment& environment) const

{

ASSERT(cssProperty() == CSSPropertyD);

- return PathInterpolationFunctions::convertValue(environment.state().style()->svgStyle().d());

+ return PathInterpolationFunctions::convertValue(environment.style().svgStyle().d());

}

PairwiseInterpolationValue CSSPathInterpolationType::maybeMergeSingles(InterpolationValue&& start, InterpolationValue&& end) const