Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 3001403002: [vm] Cleanup Instruction::Dependencies(), EffectSet, BlockEffects (Closed)

Created:
3 years, 4 months ago by alexmarkov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm] Cleanup Instruction::Dependencies(), EffectSet, BlockEffects This is the final piece of cleanup after Dart_MakeExternalString API was removed in 5b694c1b1ca4a17e5aad865c6c4feb391f1e2b66. Closes https://github.com/dart-lang/sdk/issues/30474 R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/cf28d9a5d63a7de013b345758b01dcf29735a17d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -248 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph.h View 4 chunks +0 lines, -34 lines 0 comments Download
M runtime/vm/flow_graph.cc View 3 chunks +0 lines, -107 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/intermediate_language.h View 19 chunks +7 lines, -61 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/redundancy_elimination.cc View 5 chunks +5 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
alexmarkov
3 years, 4 months ago (2017-08-22 18:27:25 UTC) #2
Vyacheslav Egorov (Google)
LGTM!
3 years, 4 months ago (2017-08-22 18:35:13 UTC) #3
alexmarkov
3 years, 4 months ago (2017-08-22 19:21:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cf28d9a5d63a7de013b345758b01dcf29735a17d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698