[vm] Cleanup Instruction::Dependencies(), EffectSet, BlockEffects

runtime/vm/intermediate_language.cc

Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 129622ffedfcee8d4c2e2bb10b0d3bd002fb51ea..418267ff25bfa1b72a6bb10314911f35c3b93b57 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -427,15 +427,6 @@ bool BinaryIntegerOpInstr::AttributesEqual(Instruction* other) const {
          (is_truncating() == other_op->is_truncating());
 }
 
-EffectSet LoadFieldInstr::Dependencies() const {
-  if (immutable_) {
-    return EffectSet::None();
-  } else {
-    UNREACHABLE();  // TODO(dartbug.com/30474): cleanup
-    return EffectSet::All();
-  }
-}
-
 bool LoadFieldInstr::AttributesEqual(Instruction* other) const {
   LoadFieldInstr* other_load = other->AsLoadField();
   ASSERT(other_load != NULL);
@@ -458,15 +449,6 @@ Instruction* InitStaticFieldInstr::Canonicalize(FlowGraph* flow_graph) {
   return is_initialized && !FLAG_fields_may_be_reset ? NULL : this;
 }
 
-EffectSet LoadStaticFieldInstr::Dependencies() const {
-  if (StaticField().is_final() && !FLAG_fields_may_be_reset) {
-    return EffectSet::None();
-  } else {
-    UNREACHABLE();  // TODO(dartbug.com/30474): cleanup
-    return EffectSet::All();
-  }
-}
-
 bool LoadStaticFieldInstr::AttributesEqual(Instruction* other) const {
   LoadStaticFieldInstr* other_load = other->AsLoadStaticField();
   ASSERT(other_load != NULL);