runtime/vm/flow_graph_range_analysis.cc - Issue 3001403002: [vm] Cleanup Instruction::Dependencies(), EffectSet, BlockEffects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_range_analysis.cc

Issue 3001403002: [vm] Cleanup Instruction::Dependencies(), EffectSet, BlockEffects (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_range_analysis.cc

diff --git a/runtime/vm/flow_graph_range_analysis.cc b/runtime/vm/flow_graph_range_analysis.cc

index a0ab8631af2896f7daf0b0e8f816fdbbee7b95e9..a99b759c69058cb775c67d86cdcbabf5b8f7ac6b 100644

--- a/runtime/vm/flow_graph_range_analysis.cc

+++ b/runtime/vm/flow_graph_range_analysis.cc

@@ -473,9 +473,7 @@ const Range* RangeAnalysis::GetIntRange(Value* value) const {

static bool AreEqualDefinitions(Definition* a, Definition* b) {

a = UnwrapConstraint(a);

b = UnwrapConstraint(b);

- return (a == b) ||

- (a->AllowsCSE() && a->Dependencies().IsNone() && b->AllowsCSE() &&

- b->Dependencies().IsNone() && a->Equals(b));

+ return (a == b) || (a->AllowsCSE() && b->AllowsCSE() && a->Equals(b));

}

static bool DependOnSameSymbol(const RangeBoundary& a, const RangeBoundary& b) {

« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »