Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2963553002: Makes PreviewsService IsPreviewsTypeEnabled aware of new CPAT Feature (Closed)

Created:
3 years, 5 months ago by dougarnett
Modified:
3 years, 5 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, megjablon
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes PreviewsService IsPreviewsTypeEnabled aware of new CPAT Feature Adds support for new DataReductionProxyDecidesTransform Feature in determining whether some preview types are enabled in the PreviewsService's IsPreviewsTypeEnabled(). BUG=735974 Review-Url: https://codereview.chromium.org/2963553002 Cr-Commit-Position: refs/heads/master@{#482653} Committed: https://chromium.googlesource.com/chromium/src/+/4305ff0e2b75705c2cc96603e8c202eade920106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M chrome/browser/previews/previews_service.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/previews/previews_service_unittest.cc View 6 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dougarnett
3 years, 5 months ago (2017-06-27 15:15:22 UTC) #4
RyanSturm
lgtm! I'm hoping we can get rid of some of the config ShouldEnable* logic at ...
3 years, 5 months ago (2017-06-27 16:50:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963553002/1
3 years, 5 months ago (2017-06-27 16:58:42 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 17:01:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4305ff0e2b75705c2cc96603e8c2...

Powered by Google App Engine
This is Rietveld 408576698