OLD | NEW |
1 // Copyright 2017 The Chromium Authors. All rights reserved. | 1 // Copyright 2017 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/previews/previews_service.h" | 5 #include "chrome/browser/previews/previews_service.h" |
6 | 6 |
7 #include <initializer_list> | 7 #include <initializer_list> |
8 #include <map> | 8 #include <map> |
9 #include <memory> | 9 #include <memory> |
10 #include <string> | 10 #include <string> |
11 | 11 |
12 #include "base/files/file_path.h" | 12 #include "base/files/file_path.h" |
13 #include "base/memory/ptr_util.h" | 13 #include "base/memory/ptr_util.h" |
14 #include "base/message_loop/message_loop.h" | 14 #include "base/message_loop/message_loop.h" |
15 #include "base/metrics/field_trial.h" | 15 #include "base/metrics/field_trial.h" |
16 #include "base/metrics/field_trial_params.h" | 16 #include "base/metrics/field_trial_params.h" |
17 #include "base/run_loop.h" | 17 #include "base/run_loop.h" |
18 #include "base/single_thread_task_runner.h" | 18 #include "base/single_thread_task_runner.h" |
| 19 #include "base/test/scoped_feature_list.h" |
| 20 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_featu
res.h" |
19 #include "components/previews/core/previews_io_data.h" | 21 #include "components/previews/core/previews_io_data.h" |
20 #include "components/previews/core/previews_ui_service.h" | 22 #include "components/previews/core/previews_ui_service.h" |
21 #include "components/variations/variations_associated_data.h" | 23 #include "components/variations/variations_associated_data.h" |
22 #include "content/public/browser/browser_thread.h" | 24 #include "content/public/browser/browser_thread.h" |
23 #include "content/public/test/test_browser_thread_bundle.h" | 25 #include "content/public/test/test_browser_thread_bundle.h" |
24 #include "testing/gtest/include/gtest/gtest.h" | 26 #include "testing/gtest/include/gtest/gtest.h" |
25 | 27 |
26 namespace { | 28 namespace { |
27 | 29 |
28 void CreateFieldTrialWithParams( | 30 void CreateFieldTrialWithParams( |
(...skipping 30 matching lines...) Expand all Loading... |
59 private: | 61 private: |
60 previews::PreviewsIsEnabledCallback enabled_callback_; | 62 previews::PreviewsIsEnabledCallback enabled_callback_; |
61 }; | 63 }; |
62 | 64 |
63 // Class to test the validity of the callback passed to PreviewsIOData from | 65 // Class to test the validity of the callback passed to PreviewsIOData from |
64 // PreviewsService. | 66 // PreviewsService. |
65 class PreviewsServiceTest : public testing::Test { | 67 class PreviewsServiceTest : public testing::Test { |
66 public: | 68 public: |
67 PreviewsServiceTest() | 69 PreviewsServiceTest() |
68 | 70 |
69 : field_trial_list_(nullptr) {} | 71 : field_trial_list_(nullptr), scoped_feature_list_() {} |
70 | 72 |
71 void SetUp() override { | 73 void SetUp() override { |
72 io_data_ = base::MakeUnique<TestPreviewsIOData>(); | 74 io_data_ = base::MakeUnique<TestPreviewsIOData>(); |
73 | 75 |
74 service_ = base::MakeUnique<PreviewsService>(); | 76 service_ = base::MakeUnique<PreviewsService>(); |
75 base::FilePath file_path; | 77 base::FilePath file_path; |
76 service_->Initialize(io_data_.get(), | 78 service_->Initialize(io_data_.get(), |
77 content::BrowserThread::GetTaskRunnerForThread( | 79 content::BrowserThread::GetTaskRunnerForThread( |
78 content::BrowserThread::UI), | 80 content::BrowserThread::UI), |
79 file_path); | 81 file_path); |
| 82 scoped_feature_list_.InitAndDisableFeature( |
| 83 data_reduction_proxy::features::kDataReductionProxyDecidesTransform); |
80 } | 84 } |
81 | 85 |
82 void TearDown() override { variations::testing::ClearAllVariationParams(); } | 86 void TearDown() override { variations::testing::ClearAllVariationParams(); } |
83 | 87 |
84 ~PreviewsServiceTest() override {} | 88 ~PreviewsServiceTest() override {} |
85 | 89 |
86 TestPreviewsIOData* io_data() const { return io_data_.get(); } | 90 TestPreviewsIOData* io_data() const { return io_data_.get(); } |
87 | 91 |
88 private: | 92 private: |
89 content::TestBrowserThreadBundle threads_; | 93 content::TestBrowserThreadBundle threads_; |
90 base::FieldTrialList field_trial_list_; | 94 base::FieldTrialList field_trial_list_; |
91 std::unique_ptr<TestPreviewsIOData> io_data_; | 95 std::unique_ptr<TestPreviewsIOData> io_data_; |
92 std::unique_ptr<PreviewsService> service_; | 96 std::unique_ptr<PreviewsService> service_; |
| 97 base::test::ScopedFeatureList scoped_feature_list_; |
93 }; | 98 }; |
94 | 99 |
95 } // namespace | 100 } // namespace |
96 | 101 |
97 TEST_F(PreviewsServiceTest, TestOfflineFieldTrialEnabled) { | 102 TEST_F(PreviewsServiceTest, TestOfflineFieldTrialEnabled) { |
98 CreateFieldTrialWithParams("ClientSidePreviews", "Enabled", | 103 CreateFieldTrialWithParams("ClientSidePreviews", "Enabled", |
99 {{"show_offline_pages", "true"}}); | 104 {{"show_offline_pages", "true"}}); |
100 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::OFFLINE)); | 105 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::OFFLINE)); |
101 } | 106 } |
102 | 107 |
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
139 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", | 144 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", |
140 "Disabled"); | 145 "Disabled"); |
141 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI)); | 146 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI)); |
142 } | 147 } |
143 | 148 |
144 TEST_F(PreviewsServiceTest, TestServerLoFiFieldTrialNotSet) { | 149 TEST_F(PreviewsServiceTest, TestServerLoFiFieldTrialNotSet) { |
145 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI)); | 150 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LOFI)); |
146 } | 151 } |
147 | 152 |
148 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialEnabledPreview) { | 153 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialEnabledPreview) { |
| 154 base::test::ScopedFeatureList scoped_feature_list; |
| 155 scoped_feature_list.InitAndDisableFeature( |
| 156 data_reduction_proxy::features::kDataReductionProxyDecidesTransform); |
149 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", | 157 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", |
150 "Enabled_Preview"); | 158 "Enabled_Preview"); |
151 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); | 159 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); |
152 } | 160 } |
153 | 161 |
154 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialEnabled) { | 162 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialEnabled) { |
155 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", "Enabled"); | 163 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", "Enabled"); |
156 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); | 164 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); |
157 } | 165 } |
158 | 166 |
159 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialDisabled) { | 167 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialDisabled) { |
160 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", | 168 base::FieldTrialList::CreateFieldTrial("DataCompressionProxyLoFi", |
161 "Disabled"); | 169 "Disabled"); |
162 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); | 170 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); |
163 } | 171 } |
164 | 172 |
165 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialNotSet) { | 173 TEST_F(PreviewsServiceTest, TestLitePageFieldTrialNotSet) { |
166 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); | 174 EXPECT_FALSE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); |
167 } | 175 } |
| 176 |
| 177 TEST_F(PreviewsServiceTest, TestServerLoFiProxyDecidesTransform) { |
| 178 base::test::ScopedFeatureList scoped_feature_list; |
| 179 scoped_feature_list.InitAndEnableFeature( |
| 180 data_reduction_proxy::features::kDataReductionProxyDecidesTransform); |
| 181 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); |
| 182 } |
| 183 |
| 184 TEST_F(PreviewsServiceTest, TestLitePageProxyDecidesTransform) { |
| 185 base::test::ScopedFeatureList scoped_feature_list; |
| 186 scoped_feature_list.InitAndEnableFeature( |
| 187 data_reduction_proxy::features::kDataReductionProxyDecidesTransform); |
| 188 EXPECT_TRUE(io_data()->IsPreviewEnabled(previews::PreviewsType::LITE_PAGE)); |
| 189 } |
OLD | NEW |