Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: chrome/browser/previews/previews_service.cc

Issue 2963553002: Makes PreviewsService IsPreviewsTypeEnabled aware of new CPAT Feature (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/previews/previews_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/previews/previews_service.cc
diff --git a/chrome/browser/previews/previews_service.cc b/chrome/browser/previews/previews_service.cc
index ead4e6e2fd9ceb6187d654c60f2fbbc5a4a04375..d103740486f2886242d7085faf05da721af1e38b 100644
--- a/chrome/browser/previews/previews_service.cc
+++ b/chrome/browser/previews/previews_service.cc
@@ -10,6 +10,7 @@
#include "base/sequenced_task_runner.h"
#include "base/task_scheduler/post_task.h"
#include "chrome/common/chrome_constants.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_features.h"
#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
#include "components/previews/core/previews_experiments.h"
#include "components/previews/core/previews_io_data.h"
@@ -22,15 +23,19 @@ namespace {
// Returns true if previews can be shown for |type|.
bool IsPreviewsTypeEnabled(previews::PreviewsType type) {
+ bool server_previews_enabled = base::FeatureList::IsEnabled(
+ data_reduction_proxy::features::kDataReductionProxyDecidesTransform);
switch (type) {
case previews::PreviewsType::OFFLINE:
return previews::params::IsOfflinePreviewsEnabled();
case previews::PreviewsType::LOFI:
- return previews::params::IsClientLoFiEnabled() ||
+ return server_previews_enabled ||
+ previews::params::IsClientLoFiEnabled() ||
data_reduction_proxy::params::IsLoFiOnViaFlags() ||
data_reduction_proxy::params::IsIncludedInLoFiEnabledFieldTrial();
case previews::PreviewsType::LITE_PAGE:
- return (data_reduction_proxy::params::IsLoFiOnViaFlags() &&
+ return server_previews_enabled ||
+ (data_reduction_proxy::params::IsLoFiOnViaFlags() &&
data_reduction_proxy::params::AreLitePagesEnabledViaFlags()) ||
data_reduction_proxy::params::IsIncludedInLitePageFieldTrial();
case previews::PreviewsType::NONE:
« no previous file with comments | « no previous file | chrome/browser/previews/previews_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698