Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node* (Closed)

Created:
3 years, 5 months ago by yosin_UTC9
Modified:
3 years, 5 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node* This patch makes |VisiblePosition::LastPositionInNode()| to take |const Node&| as |Position::LastPositionInNode()| for improving code health. This is mechanical change: s/VisiblePositon::LastPositionInNode(/VisiblePositon::LastPositionInNode(*/ BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2957833004 Cr-Commit-Position: refs/heads/master@{#482847} Committed: https://chromium.googlesource.com/chromium/src/+/b7a6b2638359a2c316f237a7f34e8be4e48844fa

Patch Set 1 : 2017-06-27T15:28:02 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 5 months ago (2017-06-27 09:49:57 UTC) #7
Xiaocheng
lgtm
3 years, 5 months ago (2017-06-27 17:04:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957833004/1
3 years, 5 months ago (2017-06-28 01:44:56 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 01:50:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7a6b2638359a2c316f237a7f34e...

Powered by Google App Engine
This is Rietveld 408576698