Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-27T15:28:02 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
index 114e2f15cb8b9a41adc312c362c2699ae1ab8d20..4db7fd6445bd599f162ace5b4daffea71e49370d 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp
@@ -135,8 +135,8 @@ TEST_F(EditingUtilitiesTest, tableElementJustBefore) {
EXPECT_EQ(table, TableElementJustBefore(
VisiblePositionInFlatTree::AfterNode(*table)));
- EXPECT_EQ(table,
- TableElementJustBefore(VisiblePosition::LastPositionInNode(table)));
+ EXPECT_EQ(table, TableElementJustBefore(
+ VisiblePosition::LastPositionInNode(*table)));
EXPECT_EQ(table, TableElementJustBefore(CreateVisiblePosition(
PositionInFlatTree::LastPositionInNode(*table))));
@@ -150,7 +150,7 @@ TEST_F(EditingUtilitiesTest, tableElementJustBefore) {
VisiblePositionInFlatTree::AfterNode(*host)));
EXPECT_EQ(nullptr,
- TableElementJustBefore(VisiblePosition::LastPositionInNode(host)));
+ TableElementJustBefore(VisiblePosition::LastPositionInNode(*host)));
EXPECT_EQ(table, TableElementJustBefore(CreateVisiblePosition(
PositionInFlatTree::LastPositionInNode(*host))));
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698