Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-27T15:28:02 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 83086eedf2ed98c917a9abf47d9eabe6056b3cb2..d273e19e463627205364c1fc08416c3b3f124d7f 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -561,7 +561,7 @@ VisiblePosition EndOfBlock(const VisiblePosition& visible_position,
position.ComputeContainerNode()
? EnclosingBlock(position.ComputeContainerNode(), rule)
: 0;
- return end_block ? VisiblePosition::LastPositionInNode(end_block)
+ return end_block ? VisiblePosition::LastPositionInNode(*end_block)
: VisiblePosition();
}
@@ -653,7 +653,7 @@ VisiblePosition EndOfEditableContent(const VisiblePosition& visible_position) {
if (!highest_root)
return VisiblePosition();
- return VisiblePosition::LastPositionInNode(highest_root);
+ return VisiblePosition::LastPositionInNode(*highest_root);
}
bool IsEndOfEditableOrNonEditableContent(const VisiblePosition& position) {

Powered by Google App Engine
This is Rietveld 408576698