Add enable_reporting to fix size regression in Cronet.

Add option to build net/ without Reporting to fix size regression in Cronet.

This was caused by https://codereview.chromium.org/2933333002.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2956023003
Cr-Commit-Position: refs/heads/master@{#483348}
Committed: https://chromium.googlesource.com/chromium/src/+/fd9d15c7367786f7d2cb115c14d287b1611c9871

[mmenke, 2017-06-27 17:25:20]

Description was changed from

==========
Add enable_reporting to fix size regression in Cronet.

This was caused by https://codereview.chromium.org/2933333002.

BUG=715695
==========

to

==========
Add enable_reporting to fix size regression in Cronet.

This was caused by https://codereview.chromium.org/2933333002.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mmenke, 2017-06-27 17:25:33]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 17:25:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-27 18:01:41]

Description was changed from

==========
Add enable_reporting to fix size regression in Cronet.

This was caused by https://codereview.chromium.org/2933333002.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Add option to build net/ without Reporting to fix size regression in Cronet.

This was caused by https://codereview.chromium.org/2933333002.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mmenke, 2017-06-27 18:01:41]

mmenke@chromium.org changed reviewers:
+ pauljensen@chromium.org

[commit-bot: I haz the power, 2017-06-27 18:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 18:55:59]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[pauljensen, 2017-06-28 13:54:23]

There are some other places that need this flag flipped for Cronet too.  I think
perhaps just mb_config.pyl in src/:
https://cs.chromium.org/search/?q=disable_ftp_support%3Dtrue+-file:ios&type=cs
But also in build/ (you can see that in the above search).

https://codereview.chromium.org/2956023003/diff/1/net/url_request/url_request...
File net/url_request/url_request_context_builder.h (right):

https://codereview.chromium.org/2956023003/diff/1/net/url_request/url_request...
net/url_request/url_request_context_builder.h:29: #include
"build/build_config.h"
#include "build/buildflag.h"

https://codereview.chromium.org/2956023003/diff/1/net/url_request/url_request...
File net/url_request/url_request_unittest.cc (right):

https://codereview.chromium.org/2956023003/diff/1/net/url_request/url_request...
net/url_request/url_request_unittest.cc:10: #include "build/build_config.h"
#include "build/buildflag.h"

[mmenke, 2017-06-28 17:58:48]

https://codereview.chromium.org/2956023003/diff/1/net/url_request/url_request...
File net/url_request/url_request_context_builder.h (right):

https://codereview.chromium.org/2956023003/diff/1/net/url_request/url_request...
net/url_request/url_request_context_builder.h:29: #include
"build/build_config.h"
On 2017/06/28 13:54:22, pauljensen wrote:
> #include "build/buildflag.h"

Done.

https://codereview.chromium.org/2956023003/diff/1/net/url_request/url_request...
File net/url_request/url_request_unittest.cc (right):

https://codereview.chromium.org/2956023003/diff/1/net/url_request/url_request...
net/url_request/url_request_unittest.cc:10: #include "build/build_config.h"
On 2017/06/28 13:54:23, pauljensen wrote:
> #include "build/buildflag.h"

Done.  I just assumed since this one had a bunch of buildflag #ifs already, it
already included.  Also defragged includes, and removed duplicates.

https://codereview.chromium.org/2956023003/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2956023003/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1680: 'use_partition_alloc=false
enable_reporting=false'),
This is the only other file I have locally that your search turned up.  I have
src/build locally, but I have no idea what build/scripts is (Note the lack of
leading "src"), or where to get it.

[pauljensen, 2017-06-28 19:10:50]

lgtm, it is a much larger change than my proposal (crrev.com/2940033002) but is
more direct and less subtle.

https://codereview.chromium.org/2956023003/diff/40001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2956023003/diff/40001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:1680: 'use_partition_alloc=false
enable_reporting=false'),
On 2017/06/28 17:58:48, mmenke wrote:
> This is the only other file I have locally that your search turned up.  I have
> src/build locally, but I have no idea what build/scripts is (Note the lack of
> leading "src"), or where to get it.

You'll need a build/ checkout; I'll email you directions.

[mmenke, 2017-06-28 19:21:34]

On 2017/06/28 19:10:50, pauljensen wrote:
> lgtm, it is a much larger change than my proposal (crrev.com/2940033002) but
is
> more direct and less subtle.

Certainly larger and less subtle.  It's also less regression prone, and may
exclude more of reporting than your proposal:  URLRequestHttpJob depends on
ReportingService, which is a non-virtual class, so I think at least it and any
non-virtual classes it depends on were being included in Cronet?

[mmenke, 2017-06-28 19:21:38]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-28 19:22:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 19:30:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 19:30:12]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[mmenke, 2017-06-28 19:36:30]

mmenke@chromium.org changed reviewers:
+ tansell@chromium.org

[mmenke, 2017-06-28 19:36:31]

[+tansell]:  Please review "mb"

[mithro, 2017-06-29 03:09:34]

lgtm

[mmenke, 2017-06-29 03:34:57]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-29 03:35:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 04:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 04:14:33]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[mmenke, 2017-06-29 04:38:18]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-06-29 04:38:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
pauljensen@chromium.org, tansell@chromium.org
Link to the patchset: https://codereview.chromium.org/2956023003/#ps60001
(title: "Move build_config header back to top, to fix windows")

[commit-bot: I haz the power, 2017-06-29 04:38:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 06:06:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 06:06:30]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[mmenke, 2017-06-29 12:38:24]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-29 12:38:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 13:45:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498739904131110,
"parent_rev": "9a833a3d14815cce147455f88a3bf856e00340a9", "commit_rev":
"fd9d15c7367786f7d2cb115c14d287b1611c9871"}

[commit-bot: I haz the power, 2017-06-29 13:46:12]

Description was changed from

==========
Add option to build net/ without Reporting to fix size regression in Cronet.

This was caused by https://codereview.chromium.org/2933333002.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Add option to build net/ without Reporting to fix size regression in Cronet.

This was caused by https://codereview.chromium.org/2933333002.

BUG=715695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2956023003
Cr-Commit-Position: refs/heads/master@{#483348}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd9d15c7367786f7d2cb115c14d2...
==========

[commit-bot: I haz the power, 2017-06-29 13:46:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fd9d15c7367786f7d2cb115c14d2...