Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: net/BUILD.gn

Issue 2956023003: Add enable_reporting to fix size regression in Cronet. (Closed)
Patch Set: Move build_config header back to top, to fix windows Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/tools/cr_cronet.py ('k') | net/features.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index b4af1e1add2ef4178cf56ba3833cf41e612c2c42..883e48ef32e547b128f21bdff088ec5386240bf8 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -51,6 +51,7 @@ buildflag_header("features") {
"DISABLE_FILE_SUPPORT=$disable_file_support",
"DISABLE_FTP_SUPPORT=$disable_ftp_support",
"ENABLE_MDNS=$enable_mdns",
+ "ENABLE_REPORTING=$enable_reporting",
"ENABLE_WEBSOCKETS=$enable_websockets",
"USE_BYTE_CERTS=$use_byte_certs",
]
@@ -1417,40 +1418,6 @@ component("net") {
"quic/quartc/quartc_stream.h",
"quic/quartc/quartc_stream_interface.h",
"quic/quartc/quartc_task_runner_interface.h",
- "reporting/reporting_browsing_data_remover.cc",
- "reporting/reporting_browsing_data_remover.h",
- "reporting/reporting_cache.cc",
- "reporting/reporting_cache.h",
- "reporting/reporting_client.cc",
- "reporting/reporting_client.h",
- "reporting/reporting_context.cc",
- "reporting/reporting_context.h",
- "reporting/reporting_delegate.cc",
- "reporting/reporting_delegate.h",
- "reporting/reporting_delivery_agent.cc",
- "reporting/reporting_delivery_agent.h",
- "reporting/reporting_endpoint_manager.cc",
- "reporting/reporting_endpoint_manager.h",
- "reporting/reporting_feature.cc",
- "reporting/reporting_feature.h",
- "reporting/reporting_garbage_collector.cc",
- "reporting/reporting_garbage_collector.h",
- "reporting/reporting_header_parser.cc",
- "reporting/reporting_header_parser.h",
- "reporting/reporting_network_change_observer.cc",
- "reporting/reporting_network_change_observer.h",
- "reporting/reporting_observer.cc",
- "reporting/reporting_observer.h",
- "reporting/reporting_persister.cc",
- "reporting/reporting_persister.h",
- "reporting/reporting_policy.cc",
- "reporting/reporting_policy.h",
- "reporting/reporting_report.cc",
- "reporting/reporting_report.h",
- "reporting/reporting_service.cc",
- "reporting/reporting_service.h",
- "reporting/reporting_uploader.cc",
- "reporting/reporting_uploader.h",
"sdch/sdch_owner.cc",
"sdch/sdch_owner.h",
"socket/client_socket_factory.cc",
@@ -1737,6 +1704,45 @@ component("net") {
"//third_party/zlib",
]
+ if (enable_reporting) {
+ sources += [
+ "reporting/reporting_browsing_data_remover.cc",
+ "reporting/reporting_browsing_data_remover.h",
+ "reporting/reporting_cache.cc",
+ "reporting/reporting_cache.h",
+ "reporting/reporting_client.cc",
+ "reporting/reporting_client.h",
+ "reporting/reporting_context.cc",
+ "reporting/reporting_context.h",
+ "reporting/reporting_delegate.cc",
+ "reporting/reporting_delegate.h",
+ "reporting/reporting_delivery_agent.cc",
+ "reporting/reporting_delivery_agent.h",
+ "reporting/reporting_endpoint_manager.cc",
+ "reporting/reporting_endpoint_manager.h",
+ "reporting/reporting_feature.cc",
+ "reporting/reporting_feature.h",
+ "reporting/reporting_garbage_collector.cc",
+ "reporting/reporting_garbage_collector.h",
+ "reporting/reporting_header_parser.cc",
+ "reporting/reporting_header_parser.h",
+ "reporting/reporting_network_change_observer.cc",
+ "reporting/reporting_network_change_observer.h",
+ "reporting/reporting_observer.cc",
+ "reporting/reporting_observer.h",
+ "reporting/reporting_persister.cc",
+ "reporting/reporting_persister.h",
+ "reporting/reporting_policy.cc",
+ "reporting/reporting_policy.h",
+ "reporting/reporting_report.cc",
+ "reporting/reporting_report.h",
+ "reporting/reporting_service.cc",
+ "reporting/reporting_service.h",
+ "reporting/reporting_uploader.cc",
+ "reporting/reporting_uploader.h",
+ ]
+ }
+
if (!use_kerberos) {
sources -= [
"http/http_auth_handler_negotiate.cc",
@@ -4936,18 +4942,6 @@ test("net_unittests") {
"quic/quartc/quartc_session_test.cc",
"quic/quartc/quartc_stream_test.cc",
"quic/test_tools/crypto_test_utils_test.cc",
- "reporting/reporting_browsing_data_remover_unittest.cc",
- "reporting/reporting_cache_unittest.cc",
- "reporting/reporting_delivery_agent_unittest.cc",
- "reporting/reporting_endpoint_manager_unittest.cc",
- "reporting/reporting_garbage_collector_unittest.cc",
- "reporting/reporting_header_parser_unittest.cc",
- "reporting/reporting_network_change_observer_unittest.cc",
- "reporting/reporting_persister_unittest.cc",
- "reporting/reporting_service_unittest.cc",
- "reporting/reporting_test_util.cc",
- "reporting/reporting_test_util.h",
- "reporting/reporting_uploader_unittest.cc",
"sdch/sdch_owner_unittest.cc",
"socket/client_socket_pool_base_unittest.cc",
"socket/mock_client_socket_pool_manager.cc",
@@ -5110,6 +5104,24 @@ test("net_unittests") {
"//url",
"//url:url_features",
]
+
+ if (enable_reporting) {
+ sources += [
+ "reporting/reporting_browsing_data_remover_unittest.cc",
+ "reporting/reporting_cache_unittest.cc",
+ "reporting/reporting_delivery_agent_unittest.cc",
+ "reporting/reporting_endpoint_manager_unittest.cc",
+ "reporting/reporting_garbage_collector_unittest.cc",
+ "reporting/reporting_header_parser_unittest.cc",
+ "reporting/reporting_network_change_observer_unittest.cc",
+ "reporting/reporting_persister_unittest.cc",
+ "reporting/reporting_service_unittest.cc",
+ "reporting/reporting_test_util.cc",
+ "reporting/reporting_test_util.h",
+ "reporting/reporting_uploader_unittest.cc",
+ ]
+ }
+
if (!is_proto_quic) {
deps += [
":extras",
« no previous file with comments | « components/cronet/tools/cr_cronet.py ('k') | net/features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698