Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: net/url_request/url_request_context_builder.h

Issue 2956023003: Add enable_reporting to fix size regression in Cronet. (Closed)
Patch Set: Move build_config header back to top, to fix windows Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/features.gni ('k') | net/url_request/url_request_context_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_context_builder.h
diff --git a/net/url_request/url_request_context_builder.h b/net/url_request/url_request_context_builder.h
index e4c77c66aa896fd69d75db0705cf7ac559ca2d81..c38dea98591d683e7b66533161a482e1ce4ff7a6 100644
--- a/net/url_request/url_request_context_builder.h
+++ b/net/url_request/url_request_context_builder.h
@@ -28,6 +28,7 @@
#include "base/memory/ref_counted.h"
#include "base/task_scheduler/task_traits.h"
#include "build/build_config.h"
+#include "build/buildflag.h"
#include "net/base/net_export.h"
#include "net/base/network_delegate.h"
#include "net/base/proxy_delegate.h"
@@ -307,10 +308,10 @@ class NET_EXPORT URLRequestContextBuilder {
void SetCertVerifier(std::unique_ptr<CertVerifier> cert_verifier);
- // Sets the reporting policy of the created request context. If not set, or
- // set to nullptr, reporting is disabled.
+#if BUILDFLAG(ENABLE_REPORTING)
void set_reporting_policy(
std::unique_ptr<net::ReportingPolicy> reporting_policy);
+#endif // BUILDFLAG(ENABLE_REPORTING)
void SetInterceptors(std::vector<std::unique_ptr<URLRequestInterceptor>>
url_request_interceptors);
@@ -411,7 +412,9 @@ class NET_EXPORT URLRequestContextBuilder {
std::unique_ptr<HttpAuthHandlerFactory> http_auth_handler_factory_;
std::unique_ptr<CertVerifier> cert_verifier_;
std::unique_ptr<CTVerifier> ct_verifier_;
+#if BUILDFLAG(ENABLE_REPORTING)
std::unique_ptr<net::ReportingPolicy> reporting_policy_;
+#endif // BUILDFLAG(ENABLE_REPORTING)
std::vector<std::unique_ptr<URLRequestInterceptor>> url_request_interceptors_;
std::unique_ptr<HttpServerProperties> http_server_properties_;
std::map<std::string, std::unique_ptr<URLRequestJobFactory::ProtocolHandler>>
« no previous file with comments | « net/features.gni ('k') | net/url_request/url_request_context_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698