Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled (Closed)

Created:
3 years, 7 months ago by Timothy Loh
Modified:
3 years, 6 months ago
Reviewers:
Lei Zhang, raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, chfremer+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix message text for modal prompts when PermissionRequestManager enabled This patch wires up the correct message text for modal permission prompts in the PermissionRequestManager code-path. BUG=606138 Review-Url: https://codereview.chromium.org/2897223002 Cr-Commit-Position: refs/heads/master@{#476201} Committed: https://chromium.googlesource.com/chromium/src/+/aa3ce260e5248cc75e61ca7540652c74dee4bf55

Patch Set 1 #

Total comments: 1

Patch Set 2 : add mic/cam in switch #

Total comments: 4

Patch Set 3 : address comments + fix desktop compile #

Patch Set 4 : ifdef getmessagetext #

Total comments: 4

Patch Set 5 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -23 lines) Patch
M chrome/browser/chrome_quota_permission_context.cc View 1 2 3 4 7 chunks +30 lines, -9 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller.cc View 1 2 3 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/permissions/permission_dialog_delegate.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/permissions/permission_prompt_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/permissions/permission_prompt_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request_impl.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request_impl.cc View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
Timothy Loh
Depends on https://codereview.chromium.org/2808003002/ to actually hook up modals at all, of course. https://codereview.chromium.org/2897223002/diff/1/chrome/browser/permissions/permission_request_impl.cc File chrome/browser/permissions/permission_request_impl.cc ...
3 years, 7 months ago (2017-05-25 03:12:08 UTC) #3
raymes
https://codereview.chromium.org/2897223002/diff/20001/chrome/browser/media/webrtc/media_stream_devices_controller.h File chrome/browser/media/webrtc/media_stream_devices_controller.h (right): https://codereview.chromium.org/2897223002/diff/20001/chrome/browser/media/webrtc/media_stream_devices_controller.h#newcode55 chrome/browser/media/webrtc/media_stream_devices_controller.h:55: base::string16 GetMessageText() const override; nit: this should move down ...
3 years, 6 months ago (2017-05-29 04:48:27 UTC) #4
Timothy Loh
https://codereview.chromium.org/2897223002/diff/20001/chrome/browser/media/webrtc/media_stream_devices_controller.h File chrome/browser/media/webrtc/media_stream_devices_controller.h (right): https://codereview.chromium.org/2897223002/diff/20001/chrome/browser/media/webrtc/media_stream_devices_controller.h#newcode55 chrome/browser/media/webrtc/media_stream_devices_controller.h:55: base::string16 GetMessageText() const override; On 2017/05/29 04:48:27, raymes wrote: ...
3 years, 6 months ago (2017-05-30 05:02:34 UTC) #9
raymes
lgtm
3 years, 6 months ago (2017-05-31 02:38:03 UTC) #12
Timothy Loh
thestig@: Could you review for OWNERS on chrome/browser/chrome_quota_permission_context.cc, chrome/browser/media/webrtc/media_stream_devices_controller.h/cc? This is part of an ongoing ...
3 years, 6 months ago (2017-05-31 03:28:22 UTC) #14
Lei Zhang
lgtm https://codereview.chromium.org/2897223002/diff/60001/chrome/browser/chrome_quota_permission_context.cc File chrome/browser/chrome_quota_permission_context.cc (right): https://codereview.chromium.org/2897223002/diff/60001/chrome/browser/chrome_quota_permission_context.cc#newcode89 chrome/browser/chrome_quota_permission_context.cc:89: // Suppress unused private field warning on desktop ...
3 years, 6 months ago (2017-05-31 07:28:23 UTC) #15
Timothy Loh
https://codereview.chromium.org/2897223002/diff/60001/chrome/browser/chrome_quota_permission_context.cc File chrome/browser/chrome_quota_permission_context.cc (right): https://codereview.chromium.org/2897223002/diff/60001/chrome/browser/chrome_quota_permission_context.cc#newcode89 chrome/browser/chrome_quota_permission_context.cc:89: // Suppress unused private field warning on desktop On ...
3 years, 6 months ago (2017-06-01 04:12:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897223002/80001
3 years, 6 months ago (2017-06-01 04:12:57 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 05:29:52 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/aa3ce260e5248cc75e61ca754065...

Powered by Google App Engine
This is Rietveld 408576698