Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: chrome/browser/permissions/permission_request_impl.h

Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled (Closed)
Patch Set: address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_IMPL_H_ 5 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_IMPL_H_
6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_IMPL_H_ 6 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_IMPL_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "chrome/browser/permissions/permission_request.h" 10 #include "chrome/browser/permissions/permission_request.h"
(...skipping 20 matching lines...) Expand all
31 const base::Closure delete_callback); 31 const base::Closure delete_callback);
32 32
33 ~PermissionRequestImpl() override; 33 ~PermissionRequestImpl() override;
34 34
35 protected: 35 protected:
36 void RegisterActionTaken() { action_taken_ = true; } 36 void RegisterActionTaken() { action_taken_ = true; }
37 37
38 private: 38 private:
39 // PermissionRequest: 39 // PermissionRequest:
40 IconId GetIconId() const override; 40 IconId GetIconId() const override;
41 #if defined(OS_ANDROID)
42 base::string16 GetMessageText() const override;
43 #endif
41 base::string16 GetMessageTextFragment() const override; 44 base::string16 GetMessageTextFragment() const override;
42 GURL GetOrigin() const override; 45 GURL GetOrigin() const override;
43 // Remember to call RegisterActionTaken for these methods if you are 46 // Remember to call RegisterActionTaken for these methods if you are
44 // overriding them. 47 // overriding them.
45 void PermissionGranted() override; 48 void PermissionGranted() override;
46 void PermissionDenied() override; 49 void PermissionDenied() override;
47 void Cancelled() override; 50 void Cancelled() override;
48 void RequestFinished() override; 51 void RequestFinished() override;
49 bool ShouldShowPersistenceToggle() const override; 52 bool ShouldShowPersistenceToggle() const override;
50 PermissionRequestType GetPermissionRequestType() const override; 53 PermissionRequestType GetPermissionRequestType() const override;
(...skipping 11 matching lines...) Expand all
62 // Called when the request is no longer in use so it can be deleted by the 65 // Called when the request is no longer in use so it can be deleted by the
63 // caller. 66 // caller.
64 const base::Closure delete_callback_; 67 const base::Closure delete_callback_;
65 bool is_finished_; 68 bool is_finished_;
66 bool action_taken_; 69 bool action_taken_;
67 70
68 DISALLOW_COPY_AND_ASSIGN(PermissionRequestImpl); 71 DISALLOW_COPY_AND_ASSIGN(PermissionRequestImpl);
69 }; 72 };
70 73
71 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_IMPL_H_ 74 #endif // CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/permissions/permission_request.h ('k') | chrome/browser/permissions/permission_request_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698