Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2897223002: Fix message text for modal prompts when PermissionRequestManager enabled (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_impl.cc
diff --git a/chrome/browser/permissions/permission_request_impl.cc b/chrome/browser/permissions/permission_request_impl.cc
index 9d252f2d8c1e361eeb27695bb2e78fe6d471dc87..cc87658778947c6961c3dd732e342f5e72425153 100644
--- a/chrome/browser/permissions/permission_request_impl.cc
+++ b/chrome/browser/permissions/permission_request_impl.cc
@@ -100,6 +100,41 @@ PermissionRequest::IconId PermissionRequestImpl::GetIconId() const {
#endif
}
+#if defined(OS_ANDROID)
+base::string16 PermissionRequestImpl::GetMessageText() const {
+ // This is currently only used for modal dialogs on Android.
+ int message_id;
+ switch (content_settings_type_) {
+ case CONTENT_SETTINGS_TYPE_GEOLOCATION:
+ message_id = IDS_GEOLOCATION_INFOBAR_QUESTION;
+ break;
+ case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
+ case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
+ message_id = IDS_NOTIFICATION_PERMISSIONS;
+ break;
+ case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
+ message_id = IDS_MIDI_SYSEX_INFOBAR_QUESTION;
+ break;
+ case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
+ message_id = IDS_PROTECTED_MEDIA_IDENTIFIER_INFOBAR_QUESTION;
+ break;
+ case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
+ message_id = IDS_MEDIA_CAPTURE_AUDIO_ONLY;
+ break;
+ case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:
+ message_id = IDS_MEDIA_CAPTURE_VIDEO_ONLY;
+ break;
+ default:
+ NOTREACHED();
+ return base::string16();
+ }
+ return l10n_util::GetStringFUTF16(
+ message_id,
+ url_formatter::FormatUrlForSecurityDisplay(
+ GetOrigin(), url_formatter::SchemeDisplay::OMIT_CRYPTOGRAPHIC));
+}
+#endif
+
base::string16 PermissionRequestImpl::GetMessageTextFragment() const {
int message_id;
switch (content_settings_type_) {
« no previous file with comments | « chrome/browser/permissions/permission_request_impl.h ('k') | chrome/browser/permissions/permission_request_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698