[vm] Use strong mode types to calculate CompileType

[vm] Use strong mode types to calculate CompileType

Strong mode types of fields, parameters and return types of
interface targets of calls are used to calculate more precise
CompileTypes of IL instructions.

R=rmacnak@google.com

Issue: https://github.com/dart-lang/sdk/issues/30480
Committed: https://github.com/dart-lang/sdk/commit/4743d90f3fb83d38910d39430cdbe570308cc2c0

[alexmarkov, 2017-08-22 17:37:47]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com, vegorov@google.com

[rmacnak, 2017-08-22 21:24:24]

lgtm

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/flow_graph_type_...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/flow_graph_type_...
runtime/vm/flow_graph_type_propagator.cc:27: OS::PrintErr("[Strong mode] Type of
%s - %s\n", instr->ToCString(),
Use THR_Print in the compiler. THR_Print applies an isolate filter, which
defaults to hiding the service isolate.

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:5314:
ASSERT(getter_name.Equals(String::Handle(interface_target->name())));
Stronger: They should both be symbols.
ASSERT(name.raw() == interface_target->name());

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:5346:
ASSERT(setter_name.Equals(String::Handle(interface_target->name())));
"

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:5583:
ASSERT(name.Equals(String::Handle(interface_target->name())));
"

[alexmarkov, 2017-08-22 22:53:11]

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/flow_graph_type_...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/flow_graph_type_...
runtime/vm/flow_graph_type_propagator.cc:27: OS::PrintErr("[Strong mode] Type of
%s - %s\n", instr->ToCString(),
On 2017/08/22 21:24:23, rmacnak wrote:
> Use THR_Print in the compiler. THR_Print applies an isolate filter, which
> defaults to hiding the service isolate.

Done.

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:5314:
ASSERT(getter_name.Equals(String::Handle(interface_target->name())));
On 2017/08/22 21:24:24, rmacnak wrote:
> Stronger: They should both be symbols.
> ASSERT(name.raw() == interface_target->name());

Done.

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:5346:
ASSERT(setter_name.Equals(String::Handle(interface_target->name())));
On 2017/08/22 21:24:24, rmacnak wrote:
> "

Done.

https://codereview.chromium.org/3004463002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:5583:
ASSERT(name.Equals(String::Handle(interface_target->name())));
On 2017/08/22 21:24:24, rmacnak wrote:
> "

Done.

[alexmarkov, 2017-08-22 22:54:19]

Description was changed from

==========
[vm] Use strong mode types to calculate CompileType

Strong mode types of fields, parameters and return types of
interface targets of calls are used to calculate more precise
CompileTypes of IL instructions.

Issue: https://github.com/dart-lang/sdk/issues/30480
==========

to

==========
[vm] Use strong mode types to calculate CompileType

Strong mode types of fields, parameters and return types of
interface targets of calls are used to calculate more precise
CompileTypes of IL instructions.

R=rmacnak@google.com

Issue: https://github.com/dart-lang/sdk/issues/30480
Committed:
https://github.com/dart-lang/sdk/commit/4743d90f3fb83d38910d39430cdbe570308cc2c0
==========

[alexmarkov, 2017-08-22 22:54:21]

Committed patchset #2 (id:20001) manually as
4743d90f3fb83d38910d39430cdbe570308cc2c0 (presubmit successful).