Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: runtime/vm/intermediate_language.h

Issue 3004463002: [vm] Use strong mode types to calculate CompileType (Closed)
Patch Set: Address review comments Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/kernel_binary_flowgraph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index b21b8669d6be272c7e77a21591b5c394d343283f..fe86fbf4a674b99adb9cb142e5d47f63e3b5ffbc 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -2912,6 +2912,8 @@ class InstanceCallInstr : public TemplateDartCall<0> {
return ic_data() == NULL ? 0 : ic_data()->AggregateCount();
}
+ virtual CompileType ComputeType() const;
+
virtual bool ComputeCanDeoptimize() const { return true; }
virtual Definition* Canonicalize(FlowGraph* flow_graph);
@@ -6751,6 +6753,8 @@ class CheckedSmiOpInstr : public TemplateDefinition<2, Throws> {
virtual bool ComputeCanDeoptimize() const { return false; }
+ virtual CompileType ComputeType() const;
+
virtual bool HasUnknownSideEffects() const { return true; }
virtual Definition* Canonicalize(FlowGraph* flow_graph);
@@ -6783,6 +6787,8 @@ class CheckedSmiComparisonInstr : public TemplateComparison<2, Throws> {
virtual bool ComputeCanDeoptimize() const { return false; }
+ virtual CompileType ComputeType() const;
+
virtual Definition* Canonicalize(FlowGraph* flow_graph);
virtual void NegateComparison() {
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/kernel_binary_flowgraph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698