Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2998113002: Reduce use of getClosureInfoForMember and cleanup closure_test (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reduce use of getClosureInfoForMember and cleanup closure_test R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/6b3f8665c05f7e33830f6f980d13ed2e6aaf2918

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -58 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 2 chunks +4 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 6 chunks +19 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/closure/data/captured_variable.dart View 3 chunks +4 lines, -4 lines 2 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_helper.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-19 12:21:19 UTC) #2
Emily Fortuna
lgtm https://codereview.chromium.org/2998113002/diff/1/tests/compiler/dart2js/closure/data/captured_variable.dart File tests/compiler/dart2js/closure/data/captured_variable.dart (left): https://codereview.chromium.org/2998113002/diff/1/tests/compiler/dart2js/closure/data/captured_variable.dart#oldcode54 tests/compiler/dart2js/closure/data/captured_variable.dart:54: /*writeLocalInClosure:boxed=[local],captured=[local],requiresBox*/ I'm confused why these get removed now?
3 years, 4 months ago (2017-08-22 20:46:17 UTC) #3
Johnni Winther
https://codereview.chromium.org/2998113002/diff/1/tests/compiler/dart2js/closure/data/captured_variable.dart File tests/compiler/dart2js/closure/data/captured_variable.dart (left): https://codereview.chromium.org/2998113002/diff/1/tests/compiler/dart2js/closure/data/captured_variable.dart#oldcode54 tests/compiler/dart2js/closure/data/captured_variable.dart:54: /*writeLocalInClosure:boxed=[local],captured=[local],requiresBox*/ On 2017/08/22 20:46:17, Emily Fortuna wrote: > I'm ...
3 years, 4 months ago (2017-08-23 07:32:21 UTC) #4
Emily Fortuna
3 years, 3 months ago (2017-08-26 00:48:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6b3f8665c05f7e33830f6f980d13ed2e6aaf2918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698