Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: pkg/compiler/lib/src/closure.dart

Issue 2998113002: Reduce use of getClosureInfoForMember and cleanup closure_test (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/closure.dart
diff --git a/pkg/compiler/lib/src/closure.dart b/pkg/compiler/lib/src/closure.dart
index 3eda671d6a0d42fe9729cd29a2d6a65edff49054..dc9001e280a99e4a4aefe686cfe5af0f1aa42411 100644
--- a/pkg/compiler/lib/src/closure.dart
+++ b/pkg/compiler/lib/src/closure.dart
@@ -46,15 +46,12 @@ abstract class ClosureDataLookup<T> {
/// This returns the same information as ScopeInfo, but can be called in
/// situations when you are sure you are dealing with a closure specifically.
- // TODO(johnniwinther,efortuna): Can we use [getScopeInfo] instead?
+ // TODO(johnniwinther,efortuna): Remove the need for this. It is now only
+ // used in inference.
ClosureRepresentationInfo getClosureInfoForMember(MemberEntity member);
ClosureRepresentationInfo getClosureInfo(T localFunction);
- ClosureRepresentationInfo getClosureInfoForMemberTesting(MemberEntity member);
-
- ClosureRepresentationInfo getClosureInfoForTesting(T localFunction);
-
/// Look up information about a loop, in case any variables it declares need
/// to be boxed/snapshotted.
CapturedLoopScope getCapturedLoopScope(T loopNode);
@@ -299,11 +296,6 @@ class ClosureTask extends ClosureConversionTask<Node> {
return _getClosureMapping(node);
}
- ClosureRepresentationInfo getClosureInfoForMemberTesting(
- MemberEntity member) {
- return getClosureInfoForMember(member);
- }
-
ClosureRepresentationInfo getClosureInfoForTesting(
covariant FunctionExpression node) {
return getClosureInfo(node);

Powered by Google App Engine
This is Rietveld 408576698