Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2959033002: Tweak accessibility of DSE FRE page to read title. (Closed)

Created:
3 years, 5 months ago by Ted C
Modified:
3 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweak accessibility of DSE FRE page to read title. Currently in the FRE, the default search engine page reads "You can change this later in settings", which is not particularly useful. This changes it so the title of the page is set at the root element for the contentDescription to ensure it is chosen as the title instead of the accessibility framework attempting to guess what to read. BUG=732490 Review-Url: https://codereview.chromium.org/2959033002 Cr-Commit-Position: refs/heads/master@{#482750} Committed: https://chromium.googlesource.com/chromium/src/+/a997f57d4858b262a4036575b1e137c79dec4fc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/res/layout/default_search_engine_first_run_fragment.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 5 months ago (2017-06-27 16:59:35 UTC) #2
gone
lgtm
3 years, 5 months ago (2017-06-27 20:45:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959033002/1
3 years, 5 months ago (2017-06-27 20:45:50 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 21:35:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a997f57d4858b262a4036575b1e1...

Powered by Google App Engine
This is Rietveld 408576698