Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/android/java/res/layout/default_search_engine_first_run_fragment.xml

Issue 2959033002: Tweak accessibility of DSE FRE page to read title. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2017 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <!-- Layout used to present a set of default search engines to the user. --> 7 <!-- Layout used to present a set of default search engines to the user. -->
8 <LinearLayout 8 <LinearLayout
9 xmlns:android="http://schemas.android.com/apk/res/android" 9 xmlns:android="http://schemas.android.com/apk/res/android"
10 xmlns:chrome="http://schemas.android.com/apk/res-auto" 10 xmlns:chrome="http://schemas.android.com/apk/res-auto"
11 android:layout_width="match_parent" 11 android:layout_width="match_parent"
12 android:layout_height="match_parent" 12 android:layout_height="match_parent"
13 android:background="@color/signin_body_background" 13 android:background="@color/signin_body_background"
14 android:contentDescription="@string/search_engine_dialog_title"
14 android:orientation="vertical" > 15 android:orientation="vertical" >
15 16
16 <FrameLayout 17 <FrameLayout
17 android:layout_width="match_parent" 18 android:layout_width="match_parent"
18 android:layout_height="0dp" 19 android:layout_height="0dp"
19 android:layout_weight="1" > 20 android:layout_weight="1" >
20 21
21 <org.chromium.chrome.browser.firstrun.FirstRunChooserView 22 <org.chromium.chrome.browser.firstrun.FirstRunChooserView
22 android:layout_width="match_parent" 23 android:layout_width="match_parent"
23 android:layout_height="match_parent" 24 android:layout_height="match_parent"
(...skipping 10 matching lines...) Expand all
34 <!-- The layout_width/layout_height is set to 16/9 dynamically i n Java --> 35 <!-- The layout_width/layout_height is set to 16/9 dynamically i n Java -->
35 <TextView 36 <TextView
36 android:id="@+id/chooser_title" 37 android:id="@+id/chooser_title"
37 android:layout_width="match_parent" 38 android:layout_width="match_parent"
38 android:layout_height="wrap_content" 39 android:layout_height="wrap_content"
39 android:gravity="bottom" 40 android:gravity="bottom"
40 android:paddingStart="@dimen/signin_chooser_padding" 41 android:paddingStart="@dimen/signin_chooser_padding"
41 android:paddingEnd="@dimen/signin_chooser_padding" 42 android:paddingEnd="@dimen/signin_chooser_padding"
42 android:paddingBottom="@dimen/signin_chooser_padding" 43 android:paddingBottom="@dimen/signin_chooser_padding"
43 android:background="@color/signin_head_background" 44 android:background="@color/signin_head_background"
45 android:importantForAccessibility="no"
44 android:textColor="@color/default_text_color" 46 android:textColor="@color/default_text_color"
45 android:textSize="@dimen/fre_title_text_size" 47 android:textSize="@dimen/fre_title_text_size"
46 android:text="@string/search_engine_dialog_title" /> 48 android:text="@string/search_engine_dialog_title" />
47 49
48 <View style="@style/Divider" /> 50 <View style="@style/Divider" />
49 51
50 <org.chromium.chrome.browser.widget.RadioButtonLayout 52 <org.chromium.chrome.browser.widget.RadioButtonLayout
51 android:id="@+id/default_search_engine_dialog_options" 53 android:id="@+id/default_search_engine_dialog_options"
52 android:layout_width="match_parent" 54 android:layout_width="match_parent"
53 android:layout_height="wrap_content" 55 android:layout_height="wrap_content"
(...skipping 24 matching lines...) Expand all
78 android:paddingStart="@dimen/fre_button_padding" 80 android:paddingStart="@dimen/fre_button_padding"
79 android:paddingEnd="@dimen/fre_button_padding" 81 android:paddingEnd="@dimen/fre_button_padding"
80 android:text="@string/ok" 82 android:text="@string/ok"
81 android:textAllCaps="true" 83 android:textAllCaps="true"
82 android:textColor="@android:color/white" 84 android:textColor="@android:color/white"
83 android:textSize="14sp" 85 android:textSize="14sp"
84 chrome:buttonColor="@color/light_active_color" 86 chrome:buttonColor="@color/light_active_color"
85 chrome:buttonRaised="false" /> 87 chrome:buttonRaised="false" />
86 88
87 </LinearLayout> 89 </LinearLayout>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698