Mojo-ify ShellViewHostMsg_LayoutDumpResponse.

Mojo-ify ShellViewHostMsg_LayoutDumpResponse.

This CL tweaks layout_test.mojom, so that a layout dump response
is sent using mojo idioms, rather than the legacy IPC.

BUG=667551
Review-Url: https://codereview.chromium.org/2955123002
Cr-Commit-Position: refs/heads/master@{#482811}
Committed: https://chromium.googlesource.com/chromium/src/+/d565a833804f202c057a33337e63d55793144cec

[Łukasz Anforowicz, 2017-06-27 16:38:15]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 16:38:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-06-27 17:27:04]

lukasza@chromium.org changed reviewers:
+ alexmos@chromium.org

[Łukasz Anforowicz, 2017-06-27 17:27:04]

alexmos@, can you PTAL?

[commit-bot: I haz the power, 2017-06-27 17:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 17:57:51]

Dry run: This issue passed the CQ dry run.

[alexmos, 2017-06-27 21:35:48]

Thanks, LGTM with nits

https://codereview.chromium.org/2955123002/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/2955123002/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/blink_test_controller.h:285: // Number of
ShellViewHostMsg_LayoutDumpResponse messages we are waiting for.
nit: update this comment.

https://codereview.chromium.org/2955123002/diff/1/content/shell/common/layout...
File content/shell/common/layout_test.mojom (right):

https://codereview.chromium.org/2955123002/diff/1/content/shell/common/layout...
content/shell/common/layout_test.mojom:39: // IPC.
nit: s/them/it/ and perhaps remove "over IPC"

https://codereview.chromium.org/2955123002/diff/1/content/shell/common/shell_...
File content/shell/common/shell_messages.h (left):

https://codereview.chromium.org/2955123002/diff/1/content/shell/common/shell_...
content/shell/common/shell_messages.h:55: // ShellViewMsg_LayoutDumpRequest /
ShellViewHostMsg_LayoutDumpResponse messages
nit: update this comment.

https://codereview.chromium.org/2955123002/diff/1/content/shell/renderer/layo...
File content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
(right):

https://codereview.chromium.org/2955123002/diff/1/content/shell/renderer/layo...
content/shell/renderer/layout_test/layout_test_render_frame_observer.cc:11:
#include "content/shell/common/shell_messages.h"
nit: is this still needed?

[Łukasz Anforowicz, 2017-06-27 22:17:00]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 22:17:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-06-27 22:17:42]

Thanks for the review.

https://codereview.chromium.org/2955123002/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/2955123002/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/blink_test_controller.h:285: // Number of
ShellViewHostMsg_LayoutDumpResponse messages we are waiting for.
On 2017/06/27 21:35:48, alexmos wrote:
> nit: update this comment.

Done.

https://codereview.chromium.org/2955123002/diff/1/content/shell/common/layout...
File content/shell/common/layout_test.mojom (right):

https://codereview.chromium.org/2955123002/diff/1/content/shell/common/layout...
content/shell/common/layout_test.mojom:39: // IPC.
On 2017/06/27 21:35:48, alexmos wrote:
> nit: s/them/it/ and perhaps remove "over IPC"

I've changed the entire comment.

https://codereview.chromium.org/2955123002/diff/1/content/shell/common/shell_...
File content/shell/common/shell_messages.h (left):

https://codereview.chromium.org/2955123002/diff/1/content/shell/common/shell_...
content/shell/common/shell_messages.h:55: // ShellViewMsg_LayoutDumpRequest /
ShellViewHostMsg_LayoutDumpResponse messages
On 2017/06/27 21:35:48, alexmos wrote:
> nit: update this comment.  

Done.

https://codereview.chromium.org/2955123002/diff/1/content/shell/renderer/layo...
File content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
(right):

https://codereview.chromium.org/2955123002/diff/1/content/shell/renderer/layo...
content/shell/renderer/layout_test/layout_test_render_frame_observer.cc:11:
#include "content/shell/common/shell_messages.h"
On 2017/06/27 21:35:48, alexmos wrote:
> nit: is this still needed?

Good catch - this is no longer needed (together with the ipc_message_macros.h).

[Łukasz Anforowicz, 2017-06-27 22:18:15]

lukasza@chromium.org changed reviewers:
+ nasko@chromium.org

[Łukasz Anforowicz, 2017-06-27 22:18:16]

nasko@, can you do a security review of:
  content/shell/common/layout_test.mojom
  content/shell/common/shell_messages.h
?

[nasko, 2017-06-27 23:08:52]

LGTM

[Łukasz Anforowicz, 2017-06-27 23:13:17]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-27 23:13:20]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-27 23:13:21]

The patchset sent to the CQ was uploaded after l-g-t-m from alexmos@chromium.org
Link to the patchset: https://codereview.chromium.org/2955123002/#ps20001
(title: "Addressed CR feedback from alexmos@.")

[commit-bot: I haz the power, 2017-06-27 23:13:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 00:16:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498605200511750,
"parent_rev": "6022f5947cba1db0d2f7f236d7de307955adf12a", "commit_rev":
"d565a833804f202c057a33337e63d55793144cec"}

[commit-bot: I haz the power, 2017-06-28 00:16:38]

Description was changed from

==========
Mojo-ify ShellViewHostMsg_LayoutDumpResponse.

This CL tweaks layout_test.mojom, so that a layout dump response
is sent using mojo idioms, rather than the legacy IPC.

BUG=667551
==========

to

==========
Mojo-ify ShellViewHostMsg_LayoutDumpResponse.

This CL tweaks layout_test.mojom, so that a layout dump response
is sent using mojo idioms, rather than the legacy IPC.

BUG=667551

Review-Url: https://codereview.chromium.org/2955123002
Cr-Commit-Position: refs/heads/master@{#482811}
Committed:
https://chromium.googlesource.com/chromium/src/+/d565a833804f202c057a33337e63...
==========

[commit-bot: I haz the power, 2017-06-28 00:16:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d565a833804f202c057a33337e63...