Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

Issue 2955123002: Mojo-ify ShellViewHostMsg_LayoutDumpResponse. (Closed)
Patch Set: Addressed CR feedback from alexmos@. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/layout_test/layout_test_render_frame_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
index e10cca7d082a9e15798e75ad9e380c59db6ab7bf..b41930234961db7ef407f3fedc91df530e4bc29f 100644
--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
@@ -8,12 +8,10 @@
#include "content/public/common/associated_interface_registry.h"
#include "content/public/renderer/render_frame.h"
-#include "content/shell/common/shell_messages.h"
#include "content/shell/renderer/layout_test/blink_test_runner.h"
#include "content/shell/renderer/layout_test/layout_test_render_thread_observer.h"
#include "content/shell/test_runner/web_test_interfaces.h"
#include "content/shell/test_runner/web_test_runner.h"
-#include "ipc/ipc_message_macros.h"
#include "third_party/WebKit/public/web/WebLocalFrame.h"
namespace content {
@@ -44,13 +42,14 @@ void LayoutTestRenderFrameObserver::OnDestruct() {
delete this;
}
-void LayoutTestRenderFrameObserver::LayoutDumpRequest() {
+void LayoutTestRenderFrameObserver::DumpFrameLayout(
+ DumpFrameLayoutCallback callback) {
std::string dump =
LayoutTestRenderThreadObserver::GetInstance()
->test_interfaces()
->TestRunner()
->DumpLayout(render_frame()->GetWebFrame());
- Send(new ShellViewHostMsg_LayoutDumpResponse(routing_id(), dump));
+ std::move(callback).Run(dump);
}
void LayoutTestRenderFrameObserver::ReplicateTestConfiguration(
« no previous file with comments | « content/shell/renderer/layout_test/layout_test_render_frame_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698