content/shell/renderer/layout_test/layout_test_render_frame_observer.h - Issue 2955123002: Mojo-ify ShellViewHostMsg_LayoutDumpResponse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

Issue 2955123002: Mojo-ify ShellViewHostMsg_LayoutDumpResponse. (Closed)

Patch Set: Addressed CR feedback from alexmos@. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/common/shell_messages.h ('k') | content/shell/renderer/layout_test/layout_test_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

index bd620c082d42431e67177865c73bf57bca87940b..cc86135eaff4867e88968b761cfc1f6b91d9b5ca 100644

--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h

@@ -22,7 +22,7 @@ class LayoutTestRenderFrameObserver : public RenderFrameObserver,

// RenderFrameObserver implementation.

void OnDestruct() override;

- void LayoutDumpRequest() override;

+ void DumpFrameLayout(DumpFrameLayoutCallback callback) override;

void SetTestConfiguration(mojom::ShellTestConfigurationPtr config) override;

void ReplicateTestConfiguration(

mojom::ShellTestConfigurationPtr config) override;

« no previous file with comments | « content/shell/common/shell_messages.h ('k') | content/shell/renderer/layout_test/layout_test_render_frame_observer.cc » ('j') | no next file with comments »