components/translate/core/browser/translate_ranker_impl_unittest.cc - Issue 2925733002: Move ranker_model_loader to a new component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_ranker_impl_unittest.cc

Issue 2925733002: Move ranker_model_loader to a new component. (Closed)

Patch Set: Adressing sdefresne's comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/translate/core/browser/translate_ranker_impl.cc ('k') | components/translate/core/browser/translate_url_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_ranker_impl_unittest.cc

diff --git a/components/translate/core/browser/translate_ranker_impl_unittest.cc b/components/translate/core/browser/translate_ranker_impl_unittest.cc

index c4be1bbdf8a11e764fa0966d61df7df184af2847..113c07da45745f93907ab4cd8ecdb24f7eb398c5 100644

--- a/components/translate/core/browser/translate_ranker_impl_unittest.cc

+++ b/components/translate/core/browser/translate_ranker_impl_unittest.cc

@@ -14,11 +14,11 @@

#include "base/task_scheduler/post_task.h"

#include "base/test/scoped_feature_list.h"

#include "base/test/scoped_task_environment.h"

+#include "components/machine_intelligence/proto/ranker_model.pb.h"

+#include "components/machine_intelligence/proto/translate_ranker_model.pb.h"

+#include "components/machine_intelligence/ranker_model.h"

#include "components/metrics/proto/translate_event.pb.h"

#include "components/metrics/proto/ukm/source.pb.h"

-#include "components/translate/core/browser/proto/ranker_model.pb.h"

-#include "components/translate/core/browser/proto/translate_ranker_model.pb.h"

-#include "components/translate/core/browser/ranker_model.h"

#include "components/ukm/test_ukm_recorder.h"

#include "components/ukm/ukm_source.h"

#include "net/url_request/test_url_fetcher_factory.h"

@@ -94,7 +94,7 @@ void TranslateRankerImplTest::InitFeatures(

std::unique_ptr<TranslateRankerImpl> TranslateRankerImplTest::GetRankerForTest(

float threshold) {

- auto model = base::MakeUnique<chrome_intelligence::RankerModel>();

+ auto model = base::MakeUnique<machine_intelligence::RankerModel>();

model->mutable_proto()->mutable_translate()->set_version(kModelVersion);

auto* details = model->mutable_proto()

->mutable_translate()