Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2925733002: Move ranker_model_loader to a new component. (Closed)
Patch Set: Adressing sdefresne's comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker_impl.cc
diff --git a/components/translate/core/browser/translate_ranker_impl.cc b/components/translate/core/browser/translate_ranker_impl.cc
index b1d587f6c88133a015b11757ea18dba8fb76d4cd..64fab4535af5b9f924b457599c837162ec50a24a 100644
--- a/components/translate/core/browser/translate_ranker_impl.cc
+++ b/components/translate/core/browser/translate_ranker_impl.cc
@@ -18,10 +18,11 @@
#include "base/strings/string_util.h"
#include "base/task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "components/machine_intelligence/proto/ranker_model.pb.h"
+#include "components/machine_intelligence/proto/translate_ranker_model.pb.h"
+#include "components/machine_intelligence/ranker_model.h"
#include "components/metrics/proto/translate_event.pb.h"
-#include "components/translate/core/browser/proto/ranker_model.pb.h"
-#include "components/translate/core/browser/proto/translate_ranker_model.pb.h"
-#include "components/translate/core/browser/ranker_model.h"
+#include "components/translate/core/browser/translate_download_manager.h"
#include "components/translate/core/common/translate_switches.h"
#include "components/ukm/public/ukm_entry_builder.h"
#include "components/ukm/public/ukm_recorder.h"
@@ -32,9 +33,10 @@ namespace translate {
namespace {
-using chrome_intelligence::RankerModel;
-using chrome_intelligence::RankerModelProto;
-using chrome_intelligence::TranslateRankerModel;
+using machine_intelligence::RankerModel;
+using machine_intelligence::RankerModelProto;
+using machine_intelligence::TranslateRankerModel;
+using machine_intelligence::RankerModelStatus;
const double kTranslationOfferDefaultThreshold = 0.5;
@@ -141,11 +143,12 @@ TranslateRankerImpl::TranslateRankerImpl(const base::FilePath& model_path,
translate::kTranslateRankerDecisionOverride)),
weak_ptr_factory_(this) {
if (is_query_enabled_ || is_enforcement_enabled_) {
- model_loader_ = base::MakeUnique<RankerModelLoader>(
+ model_loader_ = base::MakeUnique<machine_intelligence::RankerModelLoader>(
base::Bind(&ValidateModel),
base::Bind(&TranslateRankerImpl::OnModelAvailable,
weak_ptr_factory_.GetWeakPtr()),
- model_path, model_url, kUmaPrefix);
+ TranslateDownloadManager::GetInstance()->request_context(), model_path,
+ model_url, kUmaPrefix);
// Kick off the initial load from cache.
model_loader_->NotifyOfRankerActivity();
}

Powered by Google App Engine
This is Rietveld 408576698