Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: components/translate/core/browser/translate_url_fetcher.cc

Issue 2925733002: Move ranker_model_loader to a new component. (Closed)
Patch Set: Adressing sdefresne's comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_url_fetcher.cc
diff --git a/components/translate/core/browser/translate_url_fetcher.cc b/components/translate/core/browser/translate_url_fetcher.cc
index 3a2879ddb976e8d9d32d8591c5f312f0136928b4..0a0581052b8cfc1a9e1a18d11b1994e55e986d64 100644
--- a/components/translate/core/browser/translate_url_fetcher.cc
+++ b/components/translate/core/browser/translate_url_fetcher.cc
@@ -22,13 +22,10 @@ const int kMaxRetry = 16;
} // namespace
-TranslateURLFetcher::TranslateURLFetcher(int id) : id_(id),
- state_(IDLE),
- retry_count_(0) {
-}
+TranslateURLFetcher::TranslateURLFetcher(int id)
+ : id_(id), state_(IDLE), retry_count_(0) {}
-TranslateURLFetcher::~TranslateURLFetcher() {
-}
+TranslateURLFetcher::~TranslateURLFetcher() {}
bool TranslateURLFetcher::Request(
const GURL& url,
@@ -63,22 +60,17 @@ bool TranslateURLFetcher::Request(
description:
"Chrome can provide translations for the web sites visited by the "
"user. If this feature is enabled, Chrome sends network requests "
- "to download the list of supported languages, a library to perform "
- "translations, and a predictive model to know when to offer "
- "translation."
+ "to download the list of supported languages and a library to "
+ "perform translations."
trigger:
- "When Chrome starts, it downloads the list of supported langagues "
- "for translation, and a predictive model to infer whether a "
- "translation from the detected language to some other language "
- "would be useful/accepted by the user. The model is cached and the "
- "link to the latest model is provided by field study. If the "
- "latest model is already cached, it is not fetched. The first time "
- "the model decides to offer translation of a web site, it triggers "
- "a popup to ask if user wants a translation and if user approves, "
+ "When Chrome starts, it downloads the list of supported languages "
+ "for translation. The first time Chrome decides to offer "
+ "translation of a web site, it triggers a popup to ask "
+ "if user wants a translation and if user approves, "
"translation library is downloaded. The library is cached for a "
"day and is not fetched if it is available and fresh."
data:
- "Current locale is sent to fetch the list of supported lanaguges. "
+ "Current locale is sent to fetch the list of supported languages. "
"Translation library that is obtained via this interface would "
"perform actual translation, and it will send words and phrases in "
"the site to the server to translate it, but this request doesn't "
« no previous file with comments | « components/translate/core/browser/translate_ranker_impl_unittest.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698