Send BeginFrames for the renderer using Mojo

Send BeginFrames for the renderer using Mojo

It used to be the case that synthetic gestures were sent along with the 
BeginFrame to the renderer. It would make perf tests noisy if we sent
BeginFrames using mojo which does not guarantee ordering with legacy IPC.
Now after crrev.com/2886263002 BeginFrames and input events are sent
independently and it's now safe to switch to mojo. The same perf test
that was showing noise/regression before (smoothness.top_25_smooth,
mostly mean_main_thread_scroll_latency) is no longer indicating any
issues.

BUG=709689
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2890063002
Cr-Commit-Position: refs/heads/master@{#475030}
Committed: https://chromium.googlesource.com/chromium/src/+/f26257b9ee4b7e722cc05468ceecbcf3f920be22

[Saman Sami, 2017-05-17 20:57:55]

Description was changed from

==========
Send BeginFrames using Mojo
==========

to

==========
Send BeginFrames using Mojo
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-05-17 20:59:58]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 21:01:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:22:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-05-23 23:21:40]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 23:24:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 23:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 23:52:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-05-24 00:05:39]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 00:08:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 05:53:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 05:53:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-05-24 17:13:47]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:14:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 22:01:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 22:01:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Saman Sami, 2017-05-25 23:09:31]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:10:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 01:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:28:14]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-05-26 12:08:26]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-05-26 12:08:26]

LGTM given all the bots are green. I recommend landing this once piman@ is happy
with it :-)

[Saman Sami, 2017-05-26 14:24:33]

Description was changed from

==========
Send BeginFrames using Mojo
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Send BeginFrames using Mojo

It used to be the case that synthetic gestures were sent along with the 
BeginFrame to the renderer. It would make perf tests noisy if we sent
BeginFrames using mojo which does not guarantee ordering with legacy IPC.
Now after crrev.com/2886263002 BeginFrames and input events are sent
independently and it's now safe to switch to mojo.

BUG=709689

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-05-26 14:27:42]

Description was changed from

==========
Send BeginFrames using Mojo

It used to be the case that synthetic gestures were sent along with the 
BeginFrame to the renderer. It would make perf tests noisy if we sent
BeginFrames using mojo which does not guarantee ordering with legacy IPC.
Now after crrev.com/2886263002 BeginFrames and input events are sent
independently and it's now safe to switch to mojo.

BUG=709689

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Send BeginFrames using Mojo

It used to be the case that synthetic gestures were sent along with the 
BeginFrame to the renderer. It would make perf tests noisy if we sent
BeginFrames using mojo which does not guarantee ordering with legacy IPC.
Now after crrev.com/2886263002 BeginFrames and input events are sent
independently and it's now safe to switch to mojo. The same perf test
that was showing noise/regression before (smoothness.top_25_smooth,
mostly mean_main_thread_scroll_latency) is no longer indicating any
issues.

BUG=709689

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-05-26 14:28:37]

samans@chromium.org changed reviewers:
+ piman@chromium.org

[Saman Sami, 2017-05-26 14:29:07]

piman please take a look

[piman, 2017-05-26 16:23:00]

LGTM, but I think there's extra cleanup that can be had. Can be a follow-up if
you prefer.

https://codereview.chromium.org/2890063002/diff/40001/content/renderer/gpu/re...
File content/renderer/gpu/renderer_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2890063002/diff/40001/content/renderer/gpu/re...
content/renderer/gpu/renderer_compositor_frame_sink.cc:171: void
RendererCompositorFrameSink::OnMessageReceived(
Well then, if this is empty, I think we can remove
RendererCompositorFrameSinkProxy and CompositorForwardingMessageFilter
altogether.

[Saman Sami, 2017-05-26 16:27:35]

https://codereview.chromium.org/2890063002/diff/40001/content/renderer/gpu/re...
File content/renderer/gpu/renderer_compositor_frame_sink.cc (right):

https://codereview.chromium.org/2890063002/diff/40001/content/renderer/gpu/re...
content/renderer/gpu/renderer_compositor_frame_sink.cc:171: void
RendererCompositorFrameSink::OnMessageReceived(
On 2017/05/26 16:23:00, piman wrote:
> Well then, if this is empty, I think we can remove
> RendererCompositorFrameSinkProxy and CompositorForwardingMessageFilter
> altogether.

I thought about that as well. Even though it's not used now, I think I'll need
them very soon. I'll get rid of them if that's not the case.

[Saman Sami, 2017-05-26 16:28:19]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-05-26 16:28:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-05-26 16:29:10]

Description was changed from

==========
Send BeginFrames using Mojo

It used to be the case that synthetic gestures were sent along with the 
BeginFrame to the renderer. It would make perf tests noisy if we sent
BeginFrames using mojo which does not guarantee ordering with legacy IPC.
Now after crrev.com/2886263002 BeginFrames and input events are sent
independently and it's now safe to switch to mojo. The same perf test
that was showing noise/regression before (smoothness.top_25_smooth,
mostly mean_main_thread_scroll_latency) is no longer indicating any
issues.

BUG=709689

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Send BeginFrames for the renderer using Mojo

It used to be the case that synthetic gestures were sent along with the 
BeginFrame to the renderer. It would make perf tests noisy if we sent
BeginFrames using mojo which does not guarantee ordering with legacy IPC.
Now after crrev.com/2886263002 BeginFrames and input events are sent
independently and it's now safe to switch to mojo. The same perf test
that was showing noise/regression before (smoothness.top_25_smooth,
mostly mean_main_thread_scroll_latency) is no longer indicating any
issues.

BUG=709689

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-05-26 16:29:29]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-05-26 16:29:46]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-05-26 16:30:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 16:37:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495816186427000,
"parent_rev": "2fde6d35bd484cc0cb9a4b7964f0a5e2cf000a6a", "commit_rev":
"f26257b9ee4b7e722cc05468ceecbcf3f920be22"}

[commit-bot: I haz the power, 2017-05-26 16:38:02]

Description was changed from

==========
Send BeginFrames for the renderer using Mojo

It used to be the case that synthetic gestures were sent along with the 
BeginFrame to the renderer. It would make perf tests noisy if we sent
BeginFrames using mojo which does not guarantee ordering with legacy IPC.
Now after crrev.com/2886263002 BeginFrames and input events are sent
independently and it's now safe to switch to mojo. The same perf test
that was showing noise/regression before (smoothness.top_25_smooth,
mostly mean_main_thread_scroll_latency) is no longer indicating any
issues.

BUG=709689

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Send BeginFrames for the renderer using Mojo

It used to be the case that synthetic gestures were sent along with the 
BeginFrame to the renderer. It would make perf tests noisy if we sent
BeginFrames using mojo which does not guarantee ordering with legacy IPC.
Now after crrev.com/2886263002 BeginFrames and input events are sent
independently and it's now safe to switch to mojo. The same perf test
that was showing noise/regression before (smoothness.top_25_smooth,
mostly mean_main_thread_scroll_latency) is no longer indicating any
issues.

BUG=709689

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2890063002
Cr-Commit-Position: refs/heads/master@{#475030}
Committed:
https://chromium.googlesource.com/chromium/src/+/f26257b9ee4b7e722cc05468ceec...
==========

[commit-bot: I haz the power, 2017-05-26 16:38:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f26257b9ee4b7e722cc05468ceec...