Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: content/renderer/gpu/renderer_compositor_frame_sink.cc

Issue 2890063002: Send BeginFrames for the renderer using Mojo (Closed)
Patch Set: c Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/gpu/renderer_compositor_frame_sink.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/gpu/renderer_compositor_frame_sink.cc
diff --git a/content/renderer/gpu/renderer_compositor_frame_sink.cc b/content/renderer/gpu/renderer_compositor_frame_sink.cc
index 9e7dd13124f220c16f1bbf758a90b1a1cea93021..92547a90b705889c5b1a07ac9d0072274613909a 100644
--- a/content/renderer/gpu/renderer_compositor_frame_sink.cc
+++ b/content/renderer/gpu/renderer_compositor_frame_sink.cc
@@ -171,15 +171,6 @@ void RendererCompositorFrameSink::DidNotProduceFrame(
void RendererCompositorFrameSink::OnMessageReceived(
piman 2017/05/26 16:23:00 Well then, if this is empty, I think we can remove
Saman Sami 2017/05/26 16:27:35 I thought about that as well. Even though it's not
const IPC::Message& message) {
DCHECK(thread_checker_.CalledOnValidThread());
- IPC_BEGIN_MESSAGE_MAP(RendererCompositorFrameSink, message)
- IPC_MESSAGE_HANDLER(ViewMsg_BeginFrame, OnBeginFrameIPC)
- IPC_END_MESSAGE_MAP()
-}
-
-void RendererCompositorFrameSink::OnBeginFrameIPC(
- const cc::BeginFrameArgs& args) {
- if (external_begin_frame_source_)
- external_begin_frame_source_->OnBeginFrame(args);
}
void RendererCompositorFrameSink::DidReceiveCompositorFrameAck(
@@ -189,8 +180,8 @@ void RendererCompositorFrameSink::DidReceiveCompositorFrameAck(
}
void RendererCompositorFrameSink::OnBeginFrame(const cc::BeginFrameArgs& args) {
- // See crbug.com/709689.
- NOTREACHED() << "BeginFrames are delivered using Chrome IPC.";
+ if (external_begin_frame_source_)
+ external_begin_frame_source_->OnBeginFrame(args);
}
void RendererCompositorFrameSink::ReclaimResources(
« no previous file with comments | « content/renderer/gpu/renderer_compositor_frame_sink.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698