Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2779633002: [cc] Remove remaining_frames from BeginFrameAck. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
CC:
ajuma+watch_chromium.org, android-webview-reviews_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jam, jbauman+watch_chromium.org, jbroman, kalyank, kinuko+watch, nasko+codewatch_chromium.org, nona+watch_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rjkroege, rwlbuis, scheduler-bugs_chromium.org, Stephen Chennney, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[cc] Remove remaining_frames from BeginFrameAck. The remaining_frames field is not used anywhere anymore. This patch removes it (and its test) and updates BeginFrameAck creators. BUG=697086 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation TBR=piman@chromium.org, fsamuel@chromium.org, sky@chromium.org, boliu@chromium.org, reveman@chromium.org, junov@chromium.org Review-Url: https://codereview.chromium.org/2779633002 Cr-Commit-Position: refs/heads/master@{#460045} Committed: https://chromium.googlesource.com/chromium/src/+/dcb90786e5bf56b20b80e1a57df7ccd47a99a3c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -171 lines) Patch
M android_webview/browser/test/rendering_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/output/begin_frame_args.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/output/begin_frame_args.cc View 2 chunks +1 line, -4 lines 0 comments Download
M cc/scheduler/begin_frame_source.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/begin_frame_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scheduler/begin_frame_source_unittest.cc View 29 chunks +50 lines, -82 lines 0 comments Download
M cc/scheduler/scheduler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support.cc View 2 chunks +1 line, -4 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/display_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/begin_frame_args_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (15 generated)
Eric Seckler
Brian, PTAL :) The non-cc bits are rather mechanical, so adding owner reviewers as TBR: ...
3 years, 8 months ago (2017-03-27 11:45:08 UTC) #11
reveman
components/exo lgtm
3 years, 8 months ago (2017-03-27 12:40:02 UTC) #12
Fady Samuel
lgtm
3 years, 8 months ago (2017-03-27 12:42:21 UTC) #13
boliu
android_webview rs lgtm
3 years, 8 months ago (2017-03-27 17:27:34 UTC) #16
piman
lgtm
3 years, 8 months ago (2017-03-27 18:13:19 UTC) #17
Justin Novosad
lgtm
3 years, 8 months ago (2017-03-27 21:18:28 UTC) #18
brianderson
lgtm
3 years, 8 months ago (2017-03-27 22:14:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779633002/1
3 years, 8 months ago (2017-03-28 08:35:38 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 09:18:47 UTC) #24
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dcb90786e5bf56b20b80e1a57df7...

Powered by Google App Engine
This is Rietveld 408576698