Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: services/ui/ws/frame_generator_unittest.cc

Issue 2779633002: [cc] Remove remaining_frames from BeginFrameAck. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/ui/ws/frame_generator.cc ('k') | services/ui/ws/window_tree_client_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/ws/frame_generator.h" 5 #include "services/ui/ws/frame_generator.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "cc/output/compositor_frame_sink.h" 8 #include "cc/output/compositor_frame_sink.h"
9 #include "cc/scheduler/begin_frame_source.h" 9 #include "cc/scheduler/begin_frame_source.h"
10 #include "cc/test/begin_frame_args_test.cc" 10 #include "cc/test/begin_frame_args_test.cc"
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 EXPECT_EQ(1, NumberOfFramesReceived()); 236 EXPECT_EQ(1, NumberOfFramesReceived());
237 237
238 // Verify that the CompositorFrame refers to the window manager's surface via 238 // Verify that the CompositorFrame refers to the window manager's surface via
239 // referenced_surfaces. 239 // referenced_surfaces.
240 const cc::CompositorFrameMetadata& last_metadata = LastMetadata(); 240 const cc::CompositorFrameMetadata& last_metadata = LastMetadata();
241 const std::vector<cc::SurfaceId>& referenced_surfaces = 241 const std::vector<cc::SurfaceId>& referenced_surfaces =
242 last_metadata.referenced_surfaces; 242 last_metadata.referenced_surfaces;
243 EXPECT_EQ(1lu, referenced_surfaces.size()); 243 EXPECT_EQ(1lu, referenced_surfaces.size());
244 EXPECT_EQ(kArbitrarySurfaceId, referenced_surfaces.front()); 244 EXPECT_EQ(kArbitrarySurfaceId, referenced_surfaces.front());
245 245
246 cc::BeginFrameAck expected_ack(0, 2, 2, 0, true); 246 cc::BeginFrameAck expected_ack(0, 2, 2, true);
247 EXPECT_EQ(expected_ack, LastBeginFrameAck()); 247 EXPECT_EQ(expected_ack, LastBeginFrameAck());
248 EXPECT_EQ(expected_ack, last_metadata.begin_frame_ack); 248 EXPECT_EQ(expected_ack, last_metadata.begin_frame_ack);
249 249
250 // FrameGenerator stops requesting BeginFrames after submitting a 250 // FrameGenerator stops requesting BeginFrames after submitting a
251 // CompositorFrame. 251 // CompositorFrame.
252 IssueBeginFrame(); 252 IssueBeginFrame();
253 EXPECT_EQ(1, NumberOfFramesReceived()); 253 EXPECT_EQ(1, NumberOfFramesReceived());
254 EXPECT_EQ(expected_ack, LastBeginFrameAck()); 254 EXPECT_EQ(expected_ack, LastBeginFrameAck());
255 } 255 }
256 256
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 InitWithSurfaceInfo(); 343 InitWithSurfaceInfo();
344 344
345 frame_generator()->OnWindowDamaged(); 345 frame_generator()->OnWindowDamaged();
346 IssueBeginFrame(); 346 IssueBeginFrame();
347 EXPECT_EQ(2, NumberOfFramesReceived()); 347 EXPECT_EQ(2, NumberOfFramesReceived());
348 } 348 }
349 349
350 } // namespace test 350 } // namespace test
351 } // namespace ws 351 } // namespace ws
352 } // namespace ui 352 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/ws/frame_generator.cc ('k') | services/ui/ws/window_tree_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698