Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2751523007: [builtins] Generic CallInterfaceDescriptors for TFS stubs (Closed)

Created:
3 years, 9 months ago by jgruber
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, gsathya, caitp (chromium)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Generic CallInterfaceDescriptors for TFS stubs This adds a couple of generic call interface descriptors for TFS builtins with {1...4} parameters. Together with the recent Builtins::CallableFor and CSA::CallBuiltin additions, this eliminates boilerplate code for calling TFS builtins. BUG=v8:5737

Patch Set 1 #

Patch Set 2 : Remove GenericTagged0 #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -36 lines) Patch
M src/builtins/builtins.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/builtins/builtins-promise-gen.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/builtins/builtins-regexp-gen.cc View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M src/interface-descriptors.h View 1 2 3 4 chunks +32 lines, -21 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
jgruber
3 years, 9 months ago (2017-03-16 10:57:43 UTC) #4
Benedikt Meurer
lgtm
3 years, 9 months ago (2017-03-17 07:56:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523007/40001
3 years, 9 months ago (2017-03-17 08:01:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/34328) v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-17 08:03:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523007/60001
3 years, 9 months ago (2017-03-17 08:19:15 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/19082) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-17 08:20:40 UTC) #25
jgruber
3 years, 9 months ago (2017-03-17 08:30:13 UTC) #26
Holding off on landing this for now as we look into a solution that preserves
builtin-specific argument names.

Powered by Google App Engine
This is Rietveld 408576698