Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: src/builtins/builtins-regexp-gen.cc

Issue 2751523007: [builtins] Generic CallInterfaceDescriptors for TFS stubs (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-promise-gen.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-regexp-gen.cc
diff --git a/src/builtins/builtins-regexp-gen.cc b/src/builtins/builtins-regexp-gen.cc
index 953254739594abaaa0f1841ac68fa548fe680e09..4a6888d713cf18bf2f2306f00ff31408842b7764 100644
--- a/src/builtins/builtins-regexp-gen.cc
+++ b/src/builtins/builtins-regexp-gen.cc
@@ -2154,11 +2154,11 @@ void RegExpBuiltinsAssembler::RegExpPrototypeSplitBody(Node* const context,
// Helper that skips a few initial checks.
TF_BUILTIN(RegExpSplit, RegExpBuiltinsAssembler) {
- typedef RegExpSplitDescriptor Descriptor;
+ typedef GenericTagged3Descriptor Descriptor;
- Node* const regexp = Parameter(Descriptor::kReceiver);
- Node* const string = Parameter(Descriptor::kString);
- Node* const maybe_limit = Parameter(Descriptor::kLimit);
+ Node* const regexp = Parameter(Descriptor::kFirst);
+ Node* const string = Parameter(Descriptor::kSecond);
+ Node* const maybe_limit = Parameter(Descriptor::kThird);
Node* const context = Parameter(Descriptor::kContext);
CSA_ASSERT(this, IsFastRegExpMap(context, LoadMap(regexp)));
@@ -2536,11 +2536,11 @@ Node* RegExpBuiltinsAssembler::ReplaceSimpleStringFastPath(
// Helper that skips a few initial checks.
TF_BUILTIN(RegExpReplace, RegExpBuiltinsAssembler) {
- typedef RegExpReplaceDescriptor Descriptor;
+ typedef GenericTagged3Descriptor Descriptor;
- Node* const regexp = Parameter(Descriptor::kReceiver);
- Node* const string = Parameter(Descriptor::kString);
- Node* const replace_value = Parameter(Descriptor::kReplaceValue);
+ Node* const regexp = Parameter(Descriptor::kFirst);
+ Node* const string = Parameter(Descriptor::kSecond);
+ Node* const replace_value = Parameter(Descriptor::kThird);
Node* const context = Parameter(Descriptor::kContext);
CSA_ASSERT(this, IsFastRegExpMap(context, LoadMap(regexp)));
« no previous file with comments | « src/builtins/builtins-promise-gen.cc ('k') | src/interface-descriptors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698