Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3016693002: Remove support for legacy wpr_server in Telemetry

Created:
3 years, 2 months ago by nednguyen
Modified:
3 years, 2 months ago
Reviewers:
xunjieli
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Remove support for legacy wpr_server in Telemetry This doesn't delete wpr_server.py yet because some CHromium clients still depend on it. (crbug.com/767836) BUG=chromium:769284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -63 lines) Patch
M telemetry/telemetry/core/network_controller.py View 1 chunk +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/network_controller_backend.py View 6 chunks +7 lines, -20 lines 0 comments Download
M telemetry/telemetry/page/shared_page_state.py View 1 chunk +1 line, -9 lines 0 comments Download
M telemetry/telemetry/testing/fakes/__init__.py View 1 chunk +1 line, -2 lines 0 comments Download
M telemetry/telemetry/testing/serially_executed_browser_test_case.py View 1 chunk +1 line, -3 lines 0 comments Download
M telemetry/telemetry/wpr/archive_info.py View 3 chunks +2 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
nednguyen
3 years, 2 months ago (2017-09-27 19:10:44 UTC) #2
xunjieli
Looks great! LGTM
3 years, 2 months ago (2017-09-27 19:18:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3016693002/1
3 years, 2 months ago (2017-09-27 19:20:10 UTC) #8
commit-bot: I haz the power
3 years, 2 months ago (2017-09-27 19:46:27 UTC) #10 
Try jobs failed on following builders:
  Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)

Powered by Google App Engine
This is Rietveld 408576698