Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 3004503002: Renamed dtlstransportchannel.h/.cc/_unittest.cc. (Closed)

Created:
3 years, 4 months ago by Zhi Huang
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renamed dtlstransportchannel.h/.cc/_unittest.cc. Renamed the dtlstransportchannel.h/.cc to dtlstransport.h/.cc which are the right names for those files because the concept of DtlsTransportChannel no longer exists. BUG=None Review-Url: https://codereview.webrtc.org/3004503002 Cr-Commit-Position: refs/heads/master@{#19478} Committed: https://chromium.googlesource.com/external/webrtc/+/ca6d3b60b521184a9c641162cf3dfad2dd0ff9e9

Patch Set 1 : Rename dtlstransportchannel.h/.cc/_unittest.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2121 lines) Patch
M webrtc/p2p/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/p2p/base/dtlstransport.h View 6 chunks +8 lines, -11 lines 0 comments Download
A + webrtc/p2p/base/dtlstransport.cc View 6 chunks +9 lines, -11 lines 0 comments Download
A + webrtc/p2p/base/dtlstransport_unittest.cc View 10 chunks +33 lines, -30 lines 0 comments Download
D webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +0 lines, -242 lines 0 comments Download
D webrtc/p2p/base/dtlstransportchannel.cc View 1 chunk +0 lines, -687 lines 0 comments Download
D webrtc/p2p/base/dtlstransportchannel_unittest.cc View 1 chunk +0 lines, -1134 lines 0 comments Download
M webrtc/p2p/base/jseptransport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportcontroller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
Zhi Huang
PTAL. This is just a simple CL renaming the files related to DtlsTransport.
3 years, 4 months ago (2017-08-22 22:16:32 UTC) #8
Taylor Brandstetter
lgtm
3 years, 4 months ago (2017-08-23 22:50:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004503002/20001
3 years, 4 months ago (2017-08-24 00:37:39 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 01:06:00 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ca6d3b60b521184a9c641162c...

Powered by Google App Engine
This is Rietveld 408576698