Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Issue 3003543002: Add more tests for boxed variables. (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more tests for boxed variables. Landed through https://codereview.chromium.org/3003963002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -4 lines) Patch
M tests/compiler/dart2js/closure/closure_test.dart View 2 chunks +7 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/closure/data/mixed.dart View 1 chunk +71 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/closure/data/mutations.dart View 1 chunk +66 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/closure/data/nested_closures.dart View 2 chunks +32 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-21 14:02:25 UTC) #2
Emily Fortuna
3 years, 4 months ago (2017-08-22 21:42:21 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698