Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 3003163002: Add CsvOutputFormatter to Telemetry. (Closed)

Created:
3 years, 4 months ago by benjhayden
Modified:
3 years, 4 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add CsvOutputFormatter to Telemetry. CsvOutputFormatter will replace CsvPivotTableOutputFormatter. CsvOutputFormatter output contains significantly more metadata and statistics. CsvOutputFormatter preserves existing results whereas CsvPivotTableOutputFormatter does not. Sample CsvPivotTableOutputFormatter output: http://www/~benjhayden/3003163002-old.csv Sample CsvOutputFormatter output: http://www/~benjhayden/3003163002.csv http://www/~benjhayden/3003163002-new.csv BUG=catapult:#3020 Review-Url: https://codereview.chromium.org/3003163002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f8acf3b64294e71880dc283f6c39d18aa4e1ee8b

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -24 lines) Patch
A telemetry/telemetry/internal/results/csv_output_formatter.py View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
A telemetry/telemetry/internal/results/csv_output_formatter_unittest.py View 1 2 3 4 1 chunk +115 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/results/results_options.py View 1 2 3 4 4 chunks +22 lines, -7 lines 0 comments Download
M tracing/bin/histograms2csv View 2 chunks +2 lines, -8 lines 0 comments Download
M tracing/tracing/base/unit.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/add_shared_diagnostic_cmdline.html View 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/value/csv_builder.html View 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/value/csv_builder_test.html View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M tracing/tracing/value/histogram.html View 3 chunks +8 lines, -3 lines 0 comments Download
A tracing/tracing/value/histograms_to_csv.py View 1 chunk +22 lines, -0 lines 0 comments Download
M tracing/tracing/value/histograms_to_csv_cmdline.html View 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/value/merge_histograms_cmdline.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
benjhayden
PTAL
3 years, 4 months ago (2017-08-24 07:54:55 UTC) #8
eakuefner
lgtm, please add a test. and let's followup with ned/rmistry to figure out how to ...
3 years, 4 months ago (2017-08-24 22:12:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3003163002/180001
3 years, 4 months ago (2017-08-25 05:41:55 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/9018) Catapult Mac ...
3 years, 4 months ago (2017-08-25 06:02:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3003163002/200001
3 years, 4 months ago (2017-08-25 07:00:55 UTC) #19
commit-bot: I haz the power
3 years, 4 months ago (2017-08-25 07:27:54 UTC) #22
Message was sent while issue was closed.
Committed patchset #6 (id:200001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698