Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3001413002: Remove uses of the old plugin model from the analysis server (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove uses of the old plugin model from the analysis server R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b941f148a76199cc4c5029a8373cf7e6eb9d8b19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -959 lines) Patch
D pkg/analysis_server/lib/plugin/analysis/analysis_domain.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D pkg/analysis_server/lib/plugin/analysis/analyzed_files.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D pkg/analysis_server/lib/plugin/analysis/navigation/navigation.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/analysis_server/lib/plugin/edit/assist/assist.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D pkg/analysis_server/lib/plugin/edit/fix/fix.dart View 1 chunk +0 lines, -35 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 5 chunks +27 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 4 chunks +1 line, -43 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 2 chunks +10 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation.dart View 1 chunk +1 line, -26 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +0 lines, -322 lines 0 comments Download
D pkg/analysis_server/lib/src/provisional/completion/completion.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 1 chunk +0 lines, -121 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +40 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 4 chunks +0 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/status/diagnostics.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 4 chunks +0 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 6 chunks +4 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/organize_directives_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/postfix_completion_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 3 chunks +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/statement_completion_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 3 chunks +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/socket_server_test.dart View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-08-22 21:40:04 UTC) #2
scheglov
LGTM!
3 years, 3 months ago (2017-08-22 21:51:10 UTC) #3
Brian Wilkerson
3 years, 3 months ago (2017-08-23 14:42:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b941f148a76199cc4c5029a8373cf7e6eb9d8b19 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698