Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 3000233002: Remove KernelToLocalsMap.getLocalFunction (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -44 lines) Patch
M pkg/compiler/lib/src/js_model/closure.dart View 1 chunk +4 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_model/locals.dart View 2 chunks +1 line, -23 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-19 10:36:24 UTC) #2
Emily Fortuna
lgtm
3 years, 4 months ago (2017-08-22 20:28:35 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-24 07:40:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec2092793330ccbedaefb4a3bdfdc97fd198dc74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698