Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 2998223002: Make AEC3 recover more quickly for lost capture data (Closed)

Created:
3 years, 4 months ago by peah-webrtc
Modified:
3 years, 4 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make AEC3 recover more quickly for lost capture data This CL ensures that AEC3 recovers more quickly when capture data is lost in such a manner that the echo path, as seen by AEC3, becomes noncausal due to the AEC3 buffer misalignment caused by the data loss. The CL adds the assumption of a minimum echo path delay of 5 blocks and makes the hysteresis in the delay selection one-sided. BUG=chromium:757796, webrtc:8131 Review-Url: https://codereview.webrtc.org/2998223002 Cr-Commit-Position: refs/heads/master@{#19454} Committed: https://chromium.googlesource.com/external/webrtc/+/96b951c593a2665cc8688d60343dc225f62f4e99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M webrtc/modules/audio_processing/aec3/aec3_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/block_processor.cc View 1 chunk +16 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/render_delay_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
peah-webrtc
3 years, 4 months ago (2017-08-22 13:17:31 UTC) #2
ivoc
lgtm!
3 years, 4 months ago (2017-08-22 13:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998223002/1
3 years, 4 months ago (2017-08-22 13:29:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2998223002/1
3 years, 4 months ago (2017-08-22 15:31:11 UTC) #8
commit-bot: I haz the power
3 years, 4 months ago (2017-08-22 17:26:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/96b951c593a2665cc8688d603...

Powered by Google App Engine
This is Rietveld 408576698