Beef up the covariant generic parameter tear off test case

Beef up the covariant generic parameter tear off test case

This reflects some discussion that happened during the review of how
tear offs should be handled; it should help us remember to test a few
additional corner cases.

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/53553e8f611a90d04e709b72d3695e509ba04d6e

[Paul Berry, 2017-08-22 02:12:48]

paulberry@google.com changed reviewers:
+ danrubel@google.com, sigmund@google.com

[Paul Berry, 2017-08-22 02:12:48]

I only need a review from one of you.

[danrubel, 2017-08-22 21:17:45]

LGTM

https://codereview.chromium.org/2995383002/diff/1/pkg/front_end/testcases/run...
File
pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_tear_off.dart
(right):

https://codereview.chromium.org/2995383002/diff/1/pkg/front_end/testcases/run...
pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_tear_off.dart:27:
return c. /*@checkTearOff=(List<num>) -> num*/ f2;
Trying to wrap my brain around this...

G defines a function that returns a num (in this case), yet c.f2 is a function
that returns void.
Is that correct and won't trigger a static analysis error?

[Paul Berry, 2017-08-22 22:01:29]

https://codereview.chromium.org/2995383002/diff/1/pkg/front_end/testcases/run...
File
pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_tear_off.dart
(right):

https://codereview.chromium.org/2995383002/diff/1/pkg/front_end/testcases/run...
pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_tear_off.dart:27:
return c. /*@checkTearOff=(List<num>) -> num*/ f2;
On 2017/08/22 21:17:45, danrubel wrote:
> Trying to wrap my brain around this...
> 
> G defines a function that returns a num (in this case), yet c.f2 is a function
> that returns void.
> Is that correct and won't trigger a static analysis error?

Whoops, I got this wrong.  PTAL.

[danrubel, 2017-08-22 22:32:12]

LGTM

[Paul Berry, 2017-08-22 23:01:19]

Description was changed from

==========
Beef up the covariant generic parameter tear off test case

This reflects some discussion that happened during the review of how
tear offs should be handled; it should help us remember to test a few
additional corner cases.
==========

to

==========
Beef up the covariant generic parameter tear off test case

This reflects some discussion that happened during the review of how
tear offs should be handled; it should help us remember to test a few
additional corner cases.

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/53553e8f611a90d04e709b72d3695e509ba04d6e
==========

[Paul Berry, 2017-08-22 23:01:20]

Committed patchset #2 (id:20001) manually as
53553e8f611a90d04e709b72d3695e509ba04d6e (presubmit successful).