Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2995363002: Replace gflags usages with rtc_base/flags in all targets based on test_main (Closed)

Created:
3 years, 4 months ago by oprypin_webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, minyue-webrtc, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace gflags usages with rtc_base/flags in all targets based on test_main BUG=webrtc:7644 Review-Url: https://codereview.webrtc.org/2995363002 Cr-Commit-Position: refs/heads/master@{#19580} Committed: https://chromium.googlesource.com/external/webrtc/+/9b2f20c6187f29e0c5105ff436b2fc787f924976

Patch Set 1 #

Patch Set 2 : Don't drop gflags dependency #

Patch Set 3 : Fix dependency on rtc_base #

Patch Set 4 : Rebase #

Patch Set 5 : Add help flag #

Patch Set 6 : Move declare out of a header file #

Patch Set 7 : Limit the scope of this CL to targets based on test_main #

Patch Set 8 : Improve error messages #

Total comments: 3

Patch Set 9 : Various fixes #

Patch Set 10 : Fix deps #

Patch Set 11 : Drop deps #

Patch Set 12 : Fix string use after free #

Total comments: 4

Patch Set 13 : Revert irrelevant files #

Patch Set 14 : Add note about gflags/chromium #

Patch Set 15 : Fix flag validation message #

Total comments: 4

Patch Set 16 : Replace class globals #

Patch Set 17 : Fix string use after free #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -305 lines) Patch
M webrtc/audio/BUILD.gn View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/audio/test/low_bandwidth_audio_test.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 6 chunks +1 line, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_isac_quality_test.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc View 1 2 3 4 5 6 7 8 4 chunks +33 lines, -73 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -17 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 9 chunks +64 lines, -128 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +3 lines, -9 lines 0 comments Download
M webrtc/test/test_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +14 lines, -5 lines 0 comments Download
M webrtc/test/testsupport/test_output.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +13 lines, -6 lines 0 comments Download
M webrtc/test/testsupport/test_output_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 2 3 4 5 6 7 8 9 3 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/file_player_unittests.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 40 (27 generated)
oprypin_webrtc
https://codereview.webrtc.org/2995363002/diff/200001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (left): https://codereview.webrtc.org/2995363002/diff/200001/webrtc/test/BUILD.gn#oldcode166 webrtc/test/BUILD.gn:166: if (!build_with_chromium) { I suspect that this condition should ...
3 years, 4 months ago (2017-08-23 18:24:53 UTC) #13
kjellander_webrtc
https://codereview.webrtc.org/2995363002/diff/200001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (left): https://codereview.webrtc.org/2995363002/diff/200001/webrtc/test/BUILD.gn#oldcode166 webrtc/test/BUILD.gn:166: if (!build_with_chromium) { On 2017/08/23 18:24:53, oprypin_webrtc wrote: > ...
3 years, 4 months ago (2017-08-24 07:31:35 UTC) #14
oprypin_webrtc
https://codereview.webrtc.org/2995363002/diff/200001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (left): https://codereview.webrtc.org/2995363002/diff/200001/webrtc/test/BUILD.gn#oldcode166 webrtc/test/BUILD.gn:166: if (!build_with_chromium) { On 2017/08/24 07:31:34, kjellander_webrtc wrote: > ...
3 years, 4 months ago (2017-08-24 08:29:56 UTC) #15
kjellander_webrtc
lgtm
3 years, 4 months ago (2017-08-24 08:48:58 UTC) #16
kwiberg-webrtc
https://codereview.webrtc.org/2995363002/diff/380001/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc File webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc (right): https://codereview.webrtc.org/2995363002/diff/380001/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc#newcode32 webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc:32: OutputPath() + "neteq_quality_test_out.pcm"; "Variables of class type with static ...
3 years, 4 months ago (2017-08-24 09:03:44 UTC) #17
oprypin_webrtc
https://codereview.webrtc.org/2995363002/diff/380001/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc File webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc (right): https://codereview.webrtc.org/2995363002/diff/380001/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc#newcode32 webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc:32: OutputPath() + "neteq_quality_test_out.pcm"; On 2017/08/24 09:03:44, kwiberg-webrtc wrote: > ...
3 years, 3 months ago (2017-08-26 07:38:52 UTC) #22
kwiberg-webrtc
lgtm
3 years, 3 months ago (2017-08-27 22:48:50 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995363002/400001
3 years, 3 months ago (2017-08-28 10:41:48 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27038)
3 years, 3 months ago (2017-08-28 12:46:11 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995363002/420001
3 years, 3 months ago (2017-08-29 11:28:11 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: android_more_configs on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/builds/8613)
3 years, 3 months ago (2017-08-29 11:47:21 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995363002/420001
3 years, 3 months ago (2017-08-29 12:26:41 UTC) #37
commit-bot: I haz the power
3 years, 3 months ago (2017-08-29 12:52:05 UTC) #40
Message was sent while issue was closed.
Committed patchset #17 (id:420001) as
https://chromium.googlesource.com/external/webrtc/+/9b2f20c6187f29e0c5105ff43...

Powered by Google App Engine
This is Rietveld 408576698