Test the CapturedScope for local functions

Test the CapturedScope for local functions

Test changes landed through https://codereview.chromium.org/3003963002

[Johnni Winther, 2017-08-21 12:48:43]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-08-22 23:47:37]

lgtm

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:118: bool get hasBox => false;
this naming of "context" was suggested by Siggi to distinguish between the
"context" boxes here and the boxing that happens wrapping specific variables.

I'd prefer to keep it. why change it?

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:270: final ir.TreeNode node;
why not just delete it then?

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:309: /*if (freeVariables.isNotEmpty)
{
delete or uncomment?

https://codereview.chromium.org/2995353002/diff/1/tests/compiler/dart2js/clos...
File tests/compiler/dart2js/closure/closure_test.dart (right):

https://codereview.chromium.org/2995353002/diff/1/tests/compiler/dart2js/clos...
tests/compiler/dart2js/closure/closure_test.dart:263: // TODO(johnniwinther):
This can't happen!
but this is happening? 
if not... throw?

https://codereview.chromium.org/2995353002/diff/1/tests/compiler/dart2js/clos...
tests/compiler/dart2js/closure/closure_test.dart:305: //print('-------------
$object from $capturedScope');
remove commented out line?

[Johnni Winther, 2017-08-23 07:47:18]

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:118: bool get hasBox => false;
On 2017/08/22 23:47:36, Emily Fortuna wrote:
> this naming of "context" was suggested by Siggi to distinguish between the
> "context" boxes here and the boxing that happens wrapping specific variables.
> 
> I'd prefer to keep it. why change it?

[context] _is_ the box, i.e. the JS object that holds the boxed variables (at
least in my CLs).

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/2995353002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:270: final ir.TreeNode node;
On 2017/08/22 23:47:36, Emily Fortuna wrote:
> why not just delete it then?

It's good for debugging and it seemed that I might need it to correct the
free-variables issue solve in a later CL.

https://codereview.chromium.org/2995353002/diff/1/tests/compiler/dart2js/clos...
File tests/compiler/dart2js/closure/closure_test.dart (right):

https://codereview.chromium.org/2995353002/diff/1/tests/compiler/dart2js/clos...
tests/compiler/dart2js/closure/closure_test.dart:263: // TODO(johnniwinther):
This can't happen!
On 2017/08/22 23:47:37, Emily Fortuna wrote:
> but this is happening? 
> if not... throw?

I'm still in the process of making this accurate. I left it in to remember that
we cannot test the box value this way.

[Johnni Winther, 2017-08-31 13:26:37]

Description was changed from

==========
Test the CapturedScope for local functions
==========

to

==========
Test the CapturedScope for local functions

Test changes landed through https://codereview.chromium.org/3003963002
==========