Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2969223002: [media]: Replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos.

Created:
3 years, 5 months ago by riju_
Modified:
3 years, 4 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[media]: Replace LUMINANCE_F16 by R16_EXT for 9/10-bit h264 videos. LUMINANCE_F16 has following issues: 1. GL_LUMINANCE (as well as GL_ALPHA) is deprecated. 2. GpuMemoryBuffer cannot support LUMINANCE_F16. 3. LUMINANCE_F16 requires cpu int-to-float conversion. This CL introduces a media switch "kUseR16Texture" feature to use R16_EXT. If we get better power/performance numbers, we can enable R16_EXT by default. R16_EXT is : + intuitive + filterable + no int to half float CPU conversion + GpuMemoryBuffer can support R16_EXT BUG=445071, 624436 TEST=existing cc_unittests. e.g. VideoGLRendererPixelHiLoTest, CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : Fix resource multiplier in shader. #

Patch Set 3 : Rebase afer viz:: namespace changes #

Patch Set 4 : Add pixel test support for highbit texture; Remove LOGs later. #

Patch Set 5 : multiplier in shader #

Patch Set 6 : fix multiplier in pixel_test #

Patch Set 7 : rebase #

Patch Set 8 : done #

Patch Set 9 : Fix in resource_format_utils #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -15 lines) Patch
M cc/output/renderer_pixeltest.cc View 1 2 3 4 5 6 7 6 chunks +55 lines, -6 lines 0 comments Download
M cc/raster/raster_buffer_provider.cc View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 4 5 6 7 6 chunks +12 lines, -3 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 1 2 3 4 5 6 7 1 chunk +34 lines, -0 lines 0 comments Download
M cc/test/test_context_provider.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/test_in_process_context_provider.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M components/viz/common/resources/platform_color.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M components/viz/common/resources/platform_color_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/viz/common/resources/resource_format.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M components/viz/common/resources/resource_format_utils.cc View 1 2 3 4 5 6 7 8 7 chunks +8 lines, -0 lines 0 comments Download
M media/base/media_switches.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 67 (67 generated)
riju_
Description was changed from ========== [WIP] media: replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos. ...
3 years, 5 months ago (2017-07-05 11:52:14 UTC) #1
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 5 months ago (2017-07-06 10:44:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/20001
3 years, 5 months ago (2017-07-06 10:44:44 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-06 11:22:42 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/449300)
3 years, 5 months ago (2017-07-06 11:22:43 UTC) #5
riju_
Patchset #2 (id:20001) has been deleted
3 years, 5 months ago (2017-07-06 12:28:39 UTC) #6
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 5 months ago (2017-07-06 12:39:39 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/40001
3 years, 5 months ago (2017-07-06 12:39:48 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-06 14:42:26 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 5 months ago (2017-07-06 14:42:27 UTC) #10
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 5 months ago (2017-07-11 07:38:04 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/60001
3 years, 5 months ago (2017-07-11 07:38:17 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-11 09:59:53 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 5 months ago (2017-07-11 09:59:54 UTC) #14
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 5 months ago (2017-07-12 09:21:33 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/80001
3 years, 5 months ago (2017-07-12 09:21:43 UTC) #16
riju_
Description was changed from ========== [WIP] media: replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos. ...
3 years, 5 months ago (2017-07-12 09:23:36 UTC) #17
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 5 months ago (2017-07-12 09:24:40 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/80001
3 years, 5 months ago (2017-07-12 09:24:51 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-12 10:54:25 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/114287)
3 years, 5 months ago (2017-07-12 10:54:25 UTC) #21
riju_
Patchset #4 (id:80001) has been deleted
3 years, 5 months ago (2017-07-14 11:37:47 UTC) #22
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 5 months ago (2017-07-14 11:42:05 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/100001
3 years, 5 months ago (2017-07-14 11:42:07 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-14 11:58:20 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/7766)
3 years, 5 months ago (2017-07-14 11:58:21 UTC) #26
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 5 months ago (2017-07-14 12:02:40 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/100001
3 years, 5 months ago (2017-07-14 12:02:49 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-14 13:41:38 UTC) #29
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/429270)
3 years, 5 months ago (2017-07-14 13:41:41 UTC) #30
riju_
Patchset #5 (id:120001) has been deleted
3 years, 5 months ago (2017-07-18 07:42:21 UTC) #31
riju_
Patchset #4 (id:100001) has been deleted
3 years, 5 months ago (2017-07-18 07:42:29 UTC) #32
riju_
Patchset #5 (id:160001) has been deleted
3 years, 5 months ago (2017-07-19 09:16:50 UTC) #33
riju_
Patchset #4 (id:140001) has been deleted
3 years, 5 months ago (2017-07-19 09:17:02 UTC) #34
riju_
Description was changed from ========== [WIP] media: replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos. ...
3 years, 4 months ago (2017-08-10 10:03:23 UTC) #35
riju_
Patchset #6 (id:220001) has been deleted
3 years, 4 months ago (2017-08-10 13:11:28 UTC) #36
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 4 months ago (2017-08-10 14:27:49 UTC) #37
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/260001
3 years, 4 months ago (2017-08-10 14:27:52 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-10 15:15:04 UTC) #39
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/13269)
3 years, 4 months ago (2017-08-10 15:15:05 UTC) #40
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 4 months ago (2017-08-21 21:36:59 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/300001
3 years, 4 months ago (2017-08-21 21:37:10 UTC) #42
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-21 22:32:00 UTC) #43
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/494360)
3 years, 4 months ago (2017-08-21 22:32:01 UTC) #44
riju_
Patchset #9 (id:300001) has been deleted
3 years, 4 months ago (2017-08-22 20:24:59 UTC) #45
riju_
Patchset #8 (id:280001) has been deleted
3 years, 4 months ago (2017-08-22 20:25:12 UTC) #46
riju_
Description was changed from ========== [WIP] media: replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos. ...
3 years, 4 months ago (2017-08-22 22:00:04 UTC) #47
riju_
Description was changed from ========== [media]: Replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos. LUMINANCE_F16 ...
3 years, 4 months ago (2017-08-22 22:01:09 UTC) #48
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 4 months ago (2017-08-22 22:01:35 UTC) #49
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/320001
3 years, 4 months ago (2017-08-22 22:01:53 UTC) #50
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-22 22:04:40 UTC) #51
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/530197) mac_optional_gpu_tests_rel on ...
3 years, 4 months ago (2017-08-22 22:04:41 UTC) #52
riju_
Patchset #8 (id:320001) has been deleted
3 years, 4 months ago (2017-08-22 22:12:40 UTC) #53
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 4 months ago (2017-08-22 22:16:23 UTC) #54
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/340001
3 years, 4 months ago (2017-08-22 22:16:30 UTC) #55
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-23 00:24:03 UTC) #56
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 4 months ago (2017-08-23 00:24:04 UTC) #57
riju_
Description was changed from ========== [media]: Replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos. LUMINANCE_F16 ...
3 years, 4 months ago (2017-08-23 09:01:45 UTC) #58
riju_
Description was changed from ========== [media]: Replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos. LUMINANCE_F16 ...
3 years, 4 months ago (2017-08-23 09:03:22 UTC) #59
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run
3 years, 4 months ago (2017-08-23 09:12:10 UTC) #60
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2969223002/360001
3 years, 4 months ago (2017-08-23 09:12:21 UTC) #61
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-23 10:59:31 UTC) #62
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 4 months ago (2017-08-23 10:59:33 UTC) #63
riju_
Description was changed from ========== [media]: Replace LUMINANCE_F16 by R16 for 9/10-bit h264 videos. LUMINANCE_F16 ...
3 years, 4 months ago (2017-08-23 11:50:29 UTC) #64
riju_
Description was changed from ========== [media]: replace LUMINANCE_F16 by R16_EXT for 9/10-bit h264 videos. LUMINANCE_F16 ...
3 years, 4 months ago (2017-08-23 11:51:18 UTC) #65
riju_
Description was changed from ========== [media]: Replace LUMINANCE_F16 by R16_EXT for 9/10-bit h264 videos. LUMINANCE_F16 ...
3 years, 4 months ago (2017-08-23 12:01:16 UTC) #66
riju_
3 years, 4 months ago (2017-08-23 12:08:04 UTC) #67
Description was changed from

==========
[media]: Replace LUMINANCE_F16 by R16_EXT for 9/10-bit h264 videos.

LUMINANCE_F16 has following issues:
1. GL_LUMINANCE (as well as GL_ALPHA) is deprecated.
2. GpuMemoryBuffer cannot support LUMINANCE_F16.
3. LUMINANCE_F16 requires cpu int-to-float conversion.

This CL introduces a media switch "kUseR16Texture" feature to use R16_EXT.

If we get better power/performance numbers, we can enable R16_EXT
by default.

R16_EXT is :
+ intuitive
+ filterable
+ no int to half float CPU conversion


BUG=445071, 624436

TEST=existing cc_unittests. e.g. VideoGLRendererPixelHiLoTest, 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[media]: Replace LUMINANCE_F16 by R16_EXT for 9/10-bit h264 videos.

LUMINANCE_F16 has following issues:
1. GL_LUMINANCE (as well as GL_ALPHA) is deprecated.
2. GpuMemoryBuffer cannot support LUMINANCE_F16.
3. LUMINANCE_F16 requires cpu int-to-float conversion.

This CL introduces a media switch "kUseR16Texture" feature to use R16_EXT.

If we get better power/performance numbers, we can enable R16_EXT
by default.

R16_EXT is :
+ intuitive
+ filterable
+ no int to half float CPU conversion
+ GpuMemoryBuffer can support R16_EXT

BUG=445071, 624436

TEST=existing cc_unittests. e.g. VideoGLRendererPixelHiLoTest, 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Powered by Google App Engine
This is Rietveld 408576698